Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0
Date: Wed, 12 Mar 2025 13:32:27 +0300	[thread overview]
Message-ID: <20ab94fb-7942-4492-8d67-c923a00a2fbe@tarantool.org> (raw)
In-Reply-To: <5373b9f3-26f0-455f-97c6-8dd9ebc3eb50@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

Please also bump codespell version in .github/workflows/lint.yml.

On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:
>
> Hi, Sergey
>
> LGTM
>
> On 10.03.2025 17:42, Sergey Kaplun wrote:
>> This patch fixes the typo 'snapshoting' -> 'snapshotting' in the
>> <lj-736-BC_UCLO-triggers-infinite-loop.test.lua>.
>> Also, it adds `tru` and `fal` to the ignore list since they are used in
>> the LuaJIT JIT dump output.
>> ---
>>
>> Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-no-ticket-codespell-2.3.0-fixes
>> Note: CI is red due-to integrational testing problems.
>> Seehttps://github.com/tarantool/tarantool/pull/11220.
>>
>>   .codespell-ignore-words.txt                                | 2 ++
>>   .../lj-736-BC_UCLO-triggers-infinite-loop.test.lua         | 7 ++++---
>>   2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/.codespell-ignore-words.txt b/.codespell-ignore-words.txt
>> index 757ee53d..1fcceefa 100644
>> --- a/.codespell-ignore-words.txt
>> +++ b/.codespell-ignore-words.txt
>> @@ -1,3 +1,5 @@
>> +fal
>>   fpr
>>   isnt
>>   nd
>> +tru
>> diff --git a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> index 01dba4bb..3f22c203 100644
>> --- a/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> +++ b/test/tarantool-tests/lj-736-BC_UCLO-triggers-infinite-loop.test.lua
>> @@ -35,9 +35,10 @@ local function testcase()
>>   
>>       -- Records the trace for which use-def analysis is applied.
>>       for i = 1, 2 do
>> -      -- This condition triggers snapshoting and use-def analysis.
>> -      -- Before the patch this triggers the infinite loop in the
>> -      -- `snap_usedef()`, so the `goto` is never taken.
>> +      -- This condition triggers snapshotting and use-def
>> +      -- analysis. Before the patch this triggers the infinite
>> +      -- loop in the `snap_usedef()`, so the `goto` is never
>> +      -- taken.
>>         if i == 2 then
>>           goto x
>>         end

[-- Attachment #2: Type: text/html, Size: 2979 bytes --]

  reply	other threads:[~2025-03-12 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 14:42 Sergey Kaplun via Tarantool-patches
2025-03-11 11:13 ` Sergey Bronnikov via Tarantool-patches
2025-03-12 10:32   ` Sergey Bronnikov via Tarantool-patches [this message]
2025-03-18 14:36     ` Sergey Kaplun via Tarantool-patches
2025-03-19  6:40       ` Sergey Bronnikov via Tarantool-patches
2025-03-26  8:54 ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20ab94fb-7942-4492-8d67-c923a00a2fbe@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox