* [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-*
@ 2020-09-11 8:56 Alexander V. Tikhonov
2020-09-14 7:35 ` Serge Petrenko
2020-09-15 14:59 ` Kirill Yukhin
0 siblings, 2 replies; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-09-11 8:56 UTC (permalink / raw)
To: Kirill Yukhin, Serge Petrenko; +Cc: tarantool-patches
On heavy loaded hosts found the following issue:
[037] --- replication/gh-3704-misc-replica-checks-cluster-id.result Thu Sep 10 18:05:22 2020
[037] +++ replication/gh-3704-misc-replica-checks-cluster-id.reject Fri Sep 11 11:09:38 2020
[037] @@ -25,7 +25,7 @@
[037] ...
[037] box.info.replication[2].downstream.status
[037] ---
[037] -- follow
[037] +- stopped
[037] ...
[037] -- change master's cluster uuid and check that replica doesn't connect.
[037] test_run:cmd("stop server replica")
It happened because replication downstream status check occurred too
early, when it was only in 'stopped' state. To give the replication
status check routine ability to reach the needed 'follow' state, it
need to wait for it using test_run:wait_downstream() routine.
Closes #5293
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5293-fix-3704
Issue: https://github.com/tarantool/tarantool/issues/5293
.../replication/gh-3704-misc-replica-checks-cluster-id.result | 4 ++--
.../gh-3704-misc-replica-checks-cluster-id.test.lua | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.result b/test/replication/gh-3704-misc-replica-checks-cluster-id.result
index 1ca2913f8..27b4393ff 100644
--- a/test/replication/gh-3704-misc-replica-checks-cluster-id.result
+++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.result
@@ -23,9 +23,9 @@ test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH")
---
- null
...
-box.info.replication[2].downstream.status
+test_run:wait_downstream(2, {status = 'follow'})
---
-- follow
+- true
...
-- change master's cluster uuid and check that replica doesn't connect.
test_run:cmd("stop server replica")
diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
index 00c443a55..0d5378cae 100644
--- a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
+++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
@@ -9,7 +9,7 @@ test_run:cmd("create server replica with rpl_master=default, script='replication
box.schema.user.grant("guest", "replication")
test_run:cmd("start server replica")
test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH")
-box.info.replication[2].downstream.status
+test_run:wait_downstream(2, {status = 'follow'})
-- change master's cluster uuid and check that replica doesn't connect.
test_run:cmd("stop server replica")
_ = box.space._schema:replace{'cluster', tostring(uuid.new())}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-*
2020-09-11 8:56 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-* Alexander V. Tikhonov
@ 2020-09-14 7:35 ` Serge Petrenko
2020-09-15 14:59 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Serge Petrenko @ 2020-09-14 7:35 UTC (permalink / raw)
To: Alexander V. Tikhonov, Kirill Yukhin; +Cc: tarantool-patches
11.09.2020 11:56, Alexander V. Tikhonov пишет:
> On heavy loaded hosts found the following issue:
>
> [037] --- replication/gh-3704-misc-replica-checks-cluster-id.result Thu Sep 10 18:05:22 2020
> [037] +++ replication/gh-3704-misc-replica-checks-cluster-id.reject Fri Sep 11 11:09:38 2020
> [037] @@ -25,7 +25,7 @@
> [037] ...
> [037] box.info.replication[2].downstream.status
> [037] ---
> [037] -- follow
> [037] +- stopped
> [037] ...
> [037] -- change master's cluster uuid and check that replica doesn't connect.
> [037] test_run:cmd("stop server replica")
>
> It happened because replication downstream status check occurred too
> early, when it was only in 'stopped' state. To give the replication
> status check routine ability to reach the needed 'follow' state, it
> need to wait for it using test_run:wait_downstream() routine.
>
> Closes #5293
> ---
Thanks for the patch! LGTM.
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5293-fix-3704
> Issue: https://github.com/tarantool/tarantool/issues/5293
>
> .../replication/gh-3704-misc-replica-checks-cluster-id.result | 4 ++--
> .../gh-3704-misc-replica-checks-cluster-id.test.lua | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.result b/test/replication/gh-3704-misc-replica-checks-cluster-id.result
> index 1ca2913f8..27b4393ff 100644
> --- a/test/replication/gh-3704-misc-replica-checks-cluster-id.result
> +++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.result
> @@ -23,9 +23,9 @@ test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH")
> ---
> - null
> ...
> -box.info.replication[2].downstream.status
> +test_run:wait_downstream(2, {status = 'follow'})
> ---
> -- follow
> +- true
> ...
> -- change master's cluster uuid and check that replica doesn't connect.
> test_run:cmd("stop server replica")
> diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
> index 00c443a55..0d5378cae 100644
> --- a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
> +++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua
> @@ -9,7 +9,7 @@ test_run:cmd("create server replica with rpl_master=default, script='replication
> box.schema.user.grant("guest", "replication")
> test_run:cmd("start server replica")
> test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH")
> -box.info.replication[2].downstream.status
> +test_run:wait_downstream(2, {status = 'follow'})
> -- change master's cluster uuid and check that replica doesn't connect.
> test_run:cmd("stop server replica")
> _ = box.space._schema:replace{'cluster', tostring(uuid.new())}
--
Serge Petrenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-*
2020-09-11 8:56 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-* Alexander V. Tikhonov
2020-09-14 7:35 ` Serge Petrenko
@ 2020-09-15 14:59 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin @ 2020-09-15 14:59 UTC (permalink / raw)
To: Alexander V. Tikhonov; +Cc: tarantool-patches
Hello,
On 11 сен 11:56, Alexander V. Tikhonov wrote:
> On heavy loaded hosts found the following issue:
>
> [037] --- replication/gh-3704-misc-replica-checks-cluster-id.result Thu Sep 10 18:05:22 2020
> [037] +++ replication/gh-3704-misc-replica-checks-cluster-id.reject Fri Sep 11 11:09:38 2020
> [037] @@ -25,7 +25,7 @@
> [037] ...
> [037] box.info.replication[2].downstream.status
> [037] ---
> [037] -- follow
> [037] +- stopped
> [037] ...
> [037] -- change master's cluster uuid and check that replica doesn't connect.
> [037] test_run:cmd("stop server replica")
>
> It happened because replication downstream status check occurred too
> early, when it was only in 'stopped' state. To give the replication
> status check routine ability to reach the needed 'follow' state, it
> need to wait for it using test_run:wait_downstream() routine.
>
> Closes #5293
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5293-fix-3704
> Issue: https://github.com/tarantool/tarantool/issues/5293
I've checked your patch into 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 8:56 [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-* Alexander V. Tikhonov
2020-09-14 7:35 ` Serge Petrenko
2020-09-15 14:59 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox