From: Roman Khabibov <roman.habibov@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module
Date: Thu, 6 Jun 2019 18:22:55 +0300 [thread overview]
Message-ID: <20B83146-C27C-422E-A846-3E287490D53F@tarantool.org> (raw)
In-Reply-To: <20190605172850.rrapakadshzxjnjo@esperanza>
> On Jun 5, 2019, at 8:28 PM, Vladimir Davydov <vdavydov.dev@gmail.com> wrote:
>
> On Wed, Jun 05, 2019 at 08:08:39PM +0300, Roman Khabibov wrote:
>>
>>> On Jun 4, 2019, at 7:36 PM, Vladimir Davydov <vdavydov.dev@gmail.com> wrote:
>>>
>>> On Thu, May 30, 2019 at 03:36:03PM +0300, Roman Khabibov wrote:
>>>> Fetch "_vcollation" sysview to show collation name instead collation id.
>>>>
>>>> Closes #3941
>>>> ---
>>>> src/box/lua/net_box.lua | 24 ++++++++++++++++++------
>>>> test/box/net.box.result | 2 +-
>>>> test/box/stat_net.result | 4 ++--
>>>> 3 files changed, 21 insertions(+), 9 deletions(-)
>>>
>>> This one looks good to me, but you probably need to write a doc bot
>>> request.
>>>
>> What should I write in this request? I understood, that you meant
>> info about _vcollation existance.
>
> Yep, something like this I suppose:
>
> https://www.tarantool.io/en/doc/2.1/book/box/box_space/#box-space-vspace
>
> BTW we miss _vsequence documentation. Should be added as well.
_vfunc too?
next prev parent reply other threads:[~2019-06-06 15:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 12:36 [tarantool-patches] [PATCH 0/2] Add _vcollation and fetch in net.box Roman Khabibov
2019-05-30 12:36 ` [tarantool-patches] [PATCH 1/2] schema: add "_vcollation" sysview Roman Khabibov
2019-06-04 16:31 ` Vladimir Davydov
2019-06-05 17:08 ` [tarantool-patches] " Roman Khabibov
2019-06-05 17:56 ` Vladimir Davydov
2019-06-06 15:18 ` Roman Khabibov
2019-05-30 12:36 ` [tarantool-patches] [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module Roman Khabibov
2019-06-04 16:36 ` Vladimir Davydov
2019-06-05 17:08 ` [tarantool-patches] " Roman Khabibov
2019-06-05 17:28 ` Vladimir Davydov
2019-06-06 15:22 ` Roman Khabibov [this message]
2019-06-06 16:00 ` Roman Khabibov
2019-06-06 17:00 ` Vladimir Davydov
2019-06-03 18:45 ` [tarantool-patches] Re: [PATCH 0/2] Add _vcollation and fetch in net.box Vladislav Shpilevoy
2019-06-04 15:54 ` [tarantool-patches] " Vladimir Davydov
-- strict thread matches above, loose matches on Subject: below --
2019-05-16 11:24 [tarantool-patches] [PATCH 0/2] Add "_vcollation" sysview and fetch it " Roman Khabibov
2019-05-16 11:24 ` [tarantool-patches] [PATCH 2/2] net.box: fetch '_vcollation' sysview into the module Roman Khabibov
2019-05-16 12:43 ` [tarantool-patches] " Konstantin Osipov
2019-05-30 11:58 ` Konstantin Osipov
2019-05-30 12:05 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20B83146-C27C-422E-A846-3E287490D53F@tarantool.org \
--to=roman.habibov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 2/2] net.box: fetch '\''_vcollation'\'' sysview into the module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox