[Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64

[Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64

[Evgeniy Temirgaleev via Tarantool-patches]

From: Temir Galeev <temir.galeev@bk.ru>

The test `fix-mips64-spare-side-exit-patching.test.lua`
is flaky on OSX and ARM64.

The problem is in the limited range for mcode chunk's
addresses on ARM64 and in the OSX strategy for `mmap`
to ignore user's hint [1].

1. https://github.com/tarantool/tarantool/issues/13261

Branch: https://github.com/tarantool/luajit/tree/tmr_g/gh-13621-flaky-fix-mips64-se

---
 .../fix-mips64-spare-side-exit-patching.test.lua                | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
index dd9f2073..0a9e230f 100644
--- a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
+++ b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
@@ -4,6 +4,8 @@ local test = tap.test('fix-mips64-spare-side-exit-patching'):skipcond({
   ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',
   -- We need to fix the MIPS behaviour first.
   ['Disabled for MIPS architectures'] = jit.arch:match('mips'),
+  ['Disabled on *OSX/ARM64 due to #13261'] = jit.os == 'OSX' and
+                                             jit.arch:match('arm64'),
 })
 
 local generators = require('utils').jit.generators
-- 
2.49.0

Re: [Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64

[Sergey Bronnikov via Tarantool-patches]

Hello, Evgeniy!

Thanks for the patch! LGTM with minor comments below.

Sergey

On 9/28/26 09:42, Evgeniy Temirgaleev wrote:
> From: Temir Galeev <temir.galeev@bk.ru>
>
> The test `fix-mips64-spare-side-exit-patching.test.lua`
> is flaky on OSX and ARM64.
>
> The problem is in the limited range for mcode chunk's
> addresses on ARM64 and in the OSX strategy for `mmap`
> to ignore user's hint [1].
The commit message should contain a trailer "Closes 
tarantool/tarantool#13261", right?
>
> 1. https://github.com/tarantool/tarantool/issues/13261
>
> Branch: https://github.com/tarantool/luajit/tree/tmr_g/gh-13621-flaky-fix-mips64-se
>
> ---
>   .../fix-mips64-spare-side-exit-patching.test.lua                | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
> index dd9f2073..0a9e230f 100644
> --- a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
> +++ b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua
> @@ -4,6 +4,8 @@ local test = tap.test('fix-mips64-spare-side-exit-patching'):skipcond({
>     ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',
>     -- We need to fix the MIPS behaviour first.
>     ['Disabled for MIPS architectures'] = jit.arch:match('mips'),
> +  ['Disabled on *OSX/ARM64 due to #13261'] = jit.os == 'OSX' and

s/*OSX/macOS/

Feel free to ignore.

OS X is the old official name (used from 2012 to 2016). It is best 
avoided now,

except when referring to specific historical versions (e.g., OS X El 
Capitan).

macOS is the current official name. It is generally not abbreviated further.

osx / OSX is an unofficial, colloquial abbreviation. It appears in tags, 
filenames,

and casual conversation. While technically incorrect, it is widely 
recognized.


> +                                             jit.arch:match('arm64'),
>   })
>   
>   local generators = require('utils').jit.generators