Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] cmake: fixup tests build for old CMake
Date: Mon,  6 Apr 2026 16:04:07 +0300	[thread overview]
Message-ID: <20260406130407.21995-1-skaplun@tarantool.org> (raw)

This patch is a follow-up to the commit
1e5887d884be92c24ebd7c9db0a9b21ea366a0b5 ("FFI: Avoid dangling
cts->L."). The `target_link_options()` feature is introduced in CMake
3.13. Unfortunately, we have distros in Tarantool's CI with an older
default CMake version.

This patch workarounds this by the passing `LINK_FLAGS` directly.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/fix-old-cmakes

 test/tarantool-c-tests/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/tarantool-c-tests/CMakeLists.txt b/test/tarantool-c-tests/CMakeLists.txt
index 3bb20bff..ea553db8 100644
--- a/test/tarantool-c-tests/CMakeLists.txt
+++ b/test/tarantool-c-tests/CMakeLists.txt
@@ -56,11 +56,11 @@ foreach(test_source ${tests})
   )
   set_target_properties(${exe} PROPERTIES
     COMPILE_FLAGS "${TESTS_C_FLAGS}"
+    # Allow to call non-static functions via FFI.
+    LINK_FLAGS "-rdynamic"
     OUTPUT_NAME "${exe}${C_TEST_SUFFIX}"
     RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"
   )
-  # Allow to call non-static functions via FFI.
-  target_link_options(${exe} PRIVATE "-rdynamic")
   target_link_libraries(${exe} libtest ${LUAJIT_LIBRARY})
   add_dependencies(tarantool-c-tests-build ${exe})
 
-- 
2.53.0


                 reply	other threads:[~2026-04-06 13:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260406130407.21995-1-skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] cmake: fixup tests build for old CMake' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox