Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] test: fix flaky fix-slots-overflow-for-varg-record
Date: Thu, 19 Dec 2024 16:11:16 +0300	[thread overview]
Message-ID: <20241219131116.27586-1-skaplun@tarantool.org> (raw)

The aforementioned test is flaky when it is run by Tarantool, since the
necessary trace isn't compiled due to hotcount collisions. This patch
fixes this by adding the additional reset of hot counters.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-test

Tested locally on the Tarantool
Before the patch:
| ctest --repeat-until-fail 100 -R fix-slots-overflow-for-varg-record.test.lua
Failed

With the patch
| ctest --repeat-until-fail 1000 -R fix-slots-overflow-for-varg-record.test.lua
|...
| 100% tests passed, 0 tests failed out of 1

 .../fix-slots-overflow-for-varg-record.test.lua                | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
index b09a722d..7ffa6719 100644
--- a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
+++ b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
@@ -89,6 +89,9 @@ wrapper()
 
 assert(not traceinfo(1), 'no traces recorded')
 
+-- Reset hot counters to avoid collisions and blacklisting.
+jit.opt.start('hotloop=1')
+
 -- The simplest trace to compile.
 for _ = 1, 4 do end
 
-- 
2.47.0


             reply	other threads:[~2024-12-19 13:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 13:11 Sergey Kaplun via Tarantool-patches [this message]
2024-12-20 12:31 ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241219131116.27586-1-skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: fix flaky fix-slots-overflow-for-varg-record' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox