Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
	Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests
Date: Thu, 19 Dec 2024 12:30:41 +0300	[thread overview]
Message-ID: <20241219093041.14681-1-skaplun@tarantool.org> (raw)

The `strtod parsing` subtest in the <lib/base/tonumber_scan.lua> checks
the results yielded by the `strtod()` via FFI call. In glibc versions
before 2.28 it returns an incorrect result (NaN instead of inf) for
"0x3p1023" [1]. This patch hardens the skipcond for this test for a
smaller version of the libc installed.

[1]: https://sourceware.org/bugzilla/show_bug.cgi?id=23279
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-glibc-versions

The CI failure for libc 2.23 (ubuntu 16):
https://github.com/tarantool/tarantool/actions/runs/12376159316/job/34542626889?pr=10949#step:5:13916
The CI failure for libc 2.24 (debian 9):
https://github.com/tarantool/tarantool/actions/runs/12376159307/job/34542633454?pr=10949#step:5:13859
The CI failure for libc 2.27 (ubuntu 18):
https://github.com/tarantool/tarantool/actions/runs/12376159278/job/34542625496?pr=10949#step:5:11743
The CI pass for libc 2.31 (ubuntu 20):
https://github.com/tarantool/tarantool/actions/runs/12376159289/job/34542630993?pr=10949

 test/LuaJIT-tests/lib/base/tonumber_scan.lua | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/lib/base/tonumber_scan.lua b/test/LuaJIT-tests/lib/base/tonumber_scan.lua
index ac7d68a4..800c57b0 100644
--- a/test/LuaJIT-tests/lib/base/tonumber_scan.lua
+++ b/test/LuaJIT-tests/lib/base/tonumber_scan.lua
@@ -186,9 +186,11 @@ do --- tonumber parsing
   test_conv(tonumber)
 end
 
--- Skip for the old libc version with the bug in the `strtod()`.
--- See also https://sourceware.org/bugzilla/show_bug.cgi?id=16151.
-do --- strtod parsing -libc<2.19
+-- Skip for the old libc version with the bugs in the `strtod()`.
+-- Affected versions:
+-- * <2.19: https://sourceware.org/bugzilla/show_bug.cgi?id=16151.
+-- * <2.28: https://sourceware.org/bugzilla/show_bug.cgi?id=23279.
+do --- strtod parsing -libc<2.28
   test_conv(function(s)
     local d = ffi.C.strtod(s, e)
     return (e[0][0] == 0 and #s ~= 0) and d or nil
-- 
2.47.0


             reply	other threads:[~2024-12-19  9:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  9:30 Sergey Kaplun via Tarantool-patches [this message]
2024-12-20 10:59 ` Sergey Bronnikov via Tarantool-patches
2024-12-20 12:15   ` Sergey Kaplun via Tarantool-patches
2024-12-20 12:21     ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241219093041.14681-1-skaplun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: harden skipcond for libc in LuaJIT-tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox