From: mandesero--- via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org Cc: Maksim Tyushev <mandesero@gmail.com> Subject: [Tarantool-patches] [PATCH v3 luajit 0/2] Enable running tests with Valgrind, add CI Valgrind testing workflow Date: Wed, 18 Sep 2024 08:50:51 +0000 [thread overview] Message-ID: <20240918085053.150351-1-mandesero@gmail.com> (raw) From: Maksim Tyushev <mandesero@gmail.com> This patchset enables running LuaJIT tests under Valgrind, with the option to set custom Valgrind options using the `VALGRIND_OPTIONS` environment variable. Please note that this environment variable must be set before building, and any updates to it will require a project rebuild. The patchset also introduces a Valgrind testing workflow with three scenarios: full checks, and two memory checks without leak detection, where memory is filled with `0x00` and `0xff`. Some tests consistently fail under Valgrind due to various reasons, such as SIGPROF, timeouts, or flaky behavior. These tests are disabled when `LUAJIT_USE_VALGRIND=ON`. Branch: https://githb.com/tarantool/luajit/tree/mandesero/lj-3705-turn-off-strcmp-opt-in-debug Issue: https://github.com/tarantool/tarantool/issues/3705 Changes in v3: - Squashed commits 'run tests with Valgrind (1/3 v2)' and 'disable failed tests (3/3 v2)'. - Simplified `.github/actions/setup-valgrind`, now dependents on `.github/actions/setup-linux`. - Updated `test/CMakeLists.txt` with minor adjustments. Maksim Tiushev (2): cmake: run tests with Valgrind ci: add Valgrind testing workflow .github/actions/setup-valgrind/README.md | 12 +++ .github/actions/setup-valgrind/action.yml | 12 +++ .github/workflows/valgrind-testing.yaml | 95 +++++++++++++++++++ CMakeLists.txt | 5 + test/CMakeLists.txt | 16 ++++ test/tarantool-tests/CMakeLists.txt | 3 +- ...4-add-proto-trace-sysprof-default.test.lua | 1 + .../gh-7745-oom-on-trace.test.lua | 1 + .../lj-1034-tabov-error-frame.test.lua | 1 + .../lj-512-profiler-hook-finalizers.test.lua | 4 +- .../lj-726-profile-flush-close.test.lua | 4 +- .../misclib-sysprof-lapi.test.lua | 1 + 12 files changed, 152 insertions(+), 3 deletions(-) create mode 100644 .github/actions/setup-valgrind/README.md create mode 100644 .github/actions/setup-valgrind/action.yml create mode 100644 .github/workflows/valgrind-testing.yaml -- 2.34.1
next reply other threads:[~2024-09-18 8:50 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-09-18 8:50 mandesero--- via Tarantool-patches [this message] 2024-09-18 8:50 ` [Tarantool-patches] [PATCH v3 luajit 1/2] cmake: run tests with Valgrind mandesero--- via Tarantool-patches 2024-11-01 14:05 ` Sergey Bronnikov via Tarantool-patches 2024-11-11 11:03 ` mandesero--- via Tarantool-patches 2024-09-18 8:50 ` [Tarantool-patches] [PATCH v3 luajit 2/2] ci: add Valgrind testing workflow mandesero--- via Tarantool-patches 2024-11-01 14:17 ` Sergey Bronnikov via Tarantool-patches 2024-11-11 13:04 ` mandesero--- via Tarantool-patches 2024-11-01 12:51 ` [Tarantool-patches] [PATCH v3 luajit 0/2] Enable running tests with Valgrind, add CI " Sergey Bronnikov via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240918085053.150351-1-mandesero@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=mandesero@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v3 luajit 0/2] Enable running tests with Valgrind, add CI Valgrind testing workflow' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox