From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append. Date: Tue, 14 Nov 2023 18:04:55 +0300 [thread overview] Message-ID: <20231114150455.2850-1-skaplun@tarantool.org> (raw) From: Mike Pall <mike> Reported by XmiliaH. (cherry-picked from commit bc1bdbf620f58f0978385828bc51272903601e17) `bufput_append()` may fold `BUFHDR RESET` + `BUFPUT` IRs to `BUFHDR APPEND` even if the right operand (`BUFSTR`) is the PHI. If it's not the last IR in the `BUFSTR` chain, this may lead to an incorrect resulting value in the buffer, which contains a longer string since `APPEND` is used instead of `RESET`. This patch adds the corresponding check inside the fold rule. Sergey Kaplun: * added the description and the test for the problem Part of tarantool/tarantool#9145 --- Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-791-fold-bufhdr-append Tarantool PR: https://github.com/tarantool/tarantool/pull/9369 Relate issues: * https://github.com/LuaJIT/LuaJIT/issues/791 * https://github.com/tarantool/tarantool/issues/9145 src/lj_opt_fold.c | 3 +- .../lj-791-fold-bufhdr-append.test.lua | 54 +++++++++++++++++++ 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua diff --git a/src/lj_opt_fold.c b/src/lj_opt_fold.c index 944a9ecc..910cbc14 100644 --- a/src/lj_opt_fold.c +++ b/src/lj_opt_fold.c @@ -584,7 +584,8 @@ LJFOLDF(bufput_append) if ((J->flags & JIT_F_OPT_FWD) && !(fleft->op2 & IRBUFHDR_APPEND) && fleft->prev == fright->op2 && - fleft->op1 == IR(fright->op2)->op1) { + fleft->op1 == IR(fright->op2)->op1 && + !(irt_isphi(fright->t) && IR(fright->op2)->prev)) { IRRef ref = fins->op1; IR(ref)->op2 = (fleft->op2 | IRBUFHDR_APPEND); /* Modify BUFHDR. */ IR(ref)->op1 = fright->op1; diff --git a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua new file mode 100644 index 00000000..b2422159 --- /dev/null +++ b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua @@ -0,0 +1,54 @@ +local tap = require('tap') + +-- Test file to demonstrate the incorrect LuaJIT's optimization +-- `bufput_append()` for BUFPUT IR. +-- See also https://github.com/LuaJIT/LuaJIT/issues/791. + +local test = tap.test('lj-791-fold-bufhdr-append'):skipcond({ + ['Test requires JIT enabled'] = not jit.status(), +}) + +test:plan(1) + +local EMPTY_STR = '' +local prefix = 'Lu' +local result + +jit.opt.start('hotloop=1') + +-- The interesting part of IRs is the following (non-GC64 mode): +-- 0006 str BUFSTR 0005 0003 +-- 0007 > str SLOAD #2 T +-- 0008 p32 BUFHDR [0x400004a0] RESET +-- 0009 p32 BUFPUT 0008 "Lu" +-- 0010 p32 BUFPUT 0009 0007 +-- 0011 + str BUFSTR 0010 0008 +-- 0012 + int ADD 0001 +1 +-- 0013 > int LE 0012 +5 +-- 0014 > --- LOOP ------------ +-- 0015 p32 BUFHDR [0x400004a0] RESET + +-- The instruction to be folded is the following: +-- 0016 p32 BUFPUT 0015 0011 +-- +-- The 0011 operand is PHI, which is not the last IR in the BUFSTR +-- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to +-- this resulting IR: +-- p32 BUFHDR 0010 APPEND +-- Which appends to buffer instead of reseting, so the resulting +-- string contains one more symbol. + +-- XXX: Use 5 iterations to run variant part of the loop. +for _ = 1, 5 do + result = prefix .. 'a' + -- We need a non-constant string to be appended to prevent more + -- aggressive optimizations. Use an empty string for + -- convenience. Also, use a constant string in the first operand + -- in the concatenation operator for more readable `jit.dump` + -- output. + prefix = 'Lu' .. EMPTY_STR +end + +test:is(result, 'Lua', 'skipped BUFPUT APPEND optimization for PHIs') + +test:done(true) -- 2.42.0
next reply other threads:[~2023-11-14 15:09 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-14 15:04 Sergey Kaplun via Tarantool-patches [this message] 2023-11-17 11:06 ` Maxim Kokryashkin via Tarantool-patches 2023-11-20 11:21 ` Sergey Kaplun via Tarantool-patches 2023-11-24 12:50 ` Sergey Bronnikov via Tarantool-patches 2023-11-27 10:38 ` Sergey Kaplun via Tarantool-patches 2023-12-01 14:22 ` Sergey Bronnikov via Tarantool-patches 2024-01-10 8:51 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231114150455.2850-1-skaplun@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox