Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maksim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, sergeyb@tarantool.org,
	skaplun@tarantool.org, m.kokryashkin@tarantool.org
Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>
Subject: [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers
Date: Wed,  8 Nov 2023 00:06:14 +0300	[thread overview]
Message-ID: <20231107210616.53138-1-max.kokryashkin@gmail.com> (raw)

Changes in v2:
- Fixed comments as per review by Sergey Kaplun. See my answers
in the corresponding patch.

V1: https://lists.tarantool.org/tarantool-patches/20231027125738.29527-1-max.kokryashkin@gmail.com/T/#t
Branch: https://github.com/tarantool/luajit/tree/fckxorg/lj-946-print-errors-from-gc-fin
PR: https://github.com/tarantool/tarantool/pull/9315
Issues:
https://github.com/LuaJIT/LuaJIT/pull/946
https://github.com/LuaJIT/LuaJIT/issues/991
https://github.com/tarantool/tarantool/issues/9145

Mike Pall (2):
  Print errors from __gc finalizers instead of rethrowing them.
  Fix last commit.

 src/Makefile.dep.original                     | 14 +++----
 src/lib_aux.c                                 | 35 +++++++++++++++-
 src/lj_gc.c                                   | 10 ++++-
 src/lj_vmevent.h                              |  7 ++--
 test/PUC-Rio-Lua-5.1-tests/gc.lua             | 12 +++---
 ...91-fix-finalizer-error-handler-init.test.c | 30 +++++++++++++
 ...6-print-errors-from-gc-fin-custom.test.lua | 42 +++++++++++++++++++
 ...-print-errors-from-gc-fin-default.test.lua | 11 +++++
 .../script.lua                                | 24 +++++++++++
 9 files changed, 165 insertions(+), 20 deletions(-)
 create mode 100644 test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c
 create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua
 create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua
 create mode 100644 test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua

--
2.39.3 (Apple Git-145)


             reply	other threads:[~2023-11-07 21:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 21:06 Maksim Kokryashkin via Tarantool-patches [this message]
2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them Maksim Kokryashkin via Tarantool-patches
2023-11-08  8:21   ` Sergey Kaplun via Tarantool-patches
2023-11-09  0:03     ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 12:03   ` Sergey Bronnikov via Tarantool-patches
2023-11-09 12:14     ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 13:14       ` Sergey Bronnikov via Tarantool-patches
2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 2/2] Fix last commit Maksim Kokryashkin via Tarantool-patches
2023-11-08  8:37   ` Sergey Kaplun via Tarantool-patches
2023-11-09  0:04     ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 12:08   ` Sergey Bronnikov via Tarantool-patches
2023-11-23  6:30 ` [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107210616.53138-1-max.kokryashkin@gmail.com \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox