From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
skaplun@tarantool.org
Subject: [Tarantool-patches] [PATCH] sysprof: fix `SYSPROF_HANDLER_STACK_DEPTH`
Date: Wed, 11 May 2022 11:25:20 +0300 [thread overview]
Message-ID: <20220511082521.389687-4-m.kokryashkin@tarantool.org> (raw)
In-Reply-To: <20220511082521.389687-1-m.kokryashkin@tarantool.org>
This commit fixes the `SYSPROF_HANDLER_STACK_DEPTH`, by chnaging it to 6.
The `writer` function is called right after `backtrace`, so it will not
appear in the gathered backtrace.
Part of tarantool/tarantool#781
---
Branch: https://github.com/tarantool/luajit/tree/fckxorg/sysprof-rc-full-ci
src/lj_sysprof.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/lj_sysprof.c b/src/lj_sysprof.c
index 3088036f..55cea203 100644
--- a/src/lj_sysprof.c
+++ b/src/lj_sysprof.c
@@ -32,22 +32,20 @@
** Number of profiler frames we need to omit during stack
** unwinding.
** +------------------------+
-** 0 | stream_frame_host |
+** 0 | default_backtrace_host |
** +------------------------+
-** 1 | default_backtrace_host |
+** 1 | stream_backtrace_host |
** +------------------------+
-** 2 | stream_backtrace_host |
+** 2 | stream_{guest/host} |
** +------------------------+
-** 3 | stream_{guest/host} |
+** 3 | stream_event |
** +------------------------+
-** 4 | stream_event |
+** 4 | sysprof_record_sample |
** +------------------------+
-** 5 | sysprof_record_sample |
-** +------------------------+
-** 6 | sysprof_signal_handler |
+** 5 | sysprof_signal_handler |
** +------------------------+
*/
-#define SYSPROF_HANDLER_STACK_DEPTH 7
+#define SYSPROF_HANDLER_STACK_DEPTH 6
#define SYSPROF_BACKTRACE_FRAME_MAX 512
/* Check that vmstate fits in 4 bits (see streaming format) */
--
2.35.1
next prev parent reply other threads:[~2022-05-11 8:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:25 [Tarantool-patches] [PATCH] sysprof: add `LUAJIT_DISABLE_SYSPROF` to Makefile Maxim Kokryashkin via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: change C configuration API Maxim Kokryashkin via Tarantool-patches
2022-05-18 14:20 ` Igor Munkin via Tarantool-patches
2022-05-19 6:56 ` Sergey Kaplun via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: enrich symtab on a new trace or a proto Maxim Kokryashkin via Tarantool-patches
2022-05-19 14:07 ` Sergey Kaplun via Tarantool-patches
2022-05-11 8:25 ` Maxim Kokryashkin via Tarantool-patches [this message]
2022-05-18 11:06 ` [Tarantool-patches] [PATCH] sysprof: fix `SYSPROF_HANDLER_STACK_DEPTH` Igor Munkin via Tarantool-patches
2022-05-19 5:23 ` Sergey Kaplun via Tarantool-patches
2022-05-26 16:28 ` Igor Munkin via Tarantool-patches
2022-05-11 8:25 ` [Tarantool-patches] [PATCH] sysprof: make sysprof internal API funcs static Maxim Kokryashkin via Tarantool-patches
2022-05-18 9:49 ` Sergey Kaplun via Tarantool-patches
2022-05-18 11:01 ` Igor Munkin via Tarantool-patches
2022-05-26 16:28 ` Igor Munkin via Tarantool-patches
2022-05-18 10:01 ` [Tarantool-patches] [PATCH] sysprof: add `LUAJIT_DISABLE_SYSPROF` to Makefile Sergey Kaplun via Tarantool-patches
2022-05-18 10:58 ` Igor Munkin via Tarantool-patches
2022-05-26 16:25 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511082521.389687-4-m.kokryashkin@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sysprof: fix `SYSPROF_HANDLER_STACK_DEPTH`' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox