* [Tarantool-patches] [PATCH v2] net.box: add predefined system events for pub/sub
@ 2022-01-20 4:06 Yan Shtunder via Tarantool-patches
2022-01-27 0:23 ` Vladislav Shpilevoy via Tarantool-patches
0 siblings, 1 reply; 2+ messages in thread
From: Yan Shtunder via Tarantool-patches @ 2022-01-20 4:06 UTC (permalink / raw)
To: v.shpilevoy; +Cc: tarantool-patches, Yan Shtunder
Adding predefined system event box.status and box.election
Part of #6260
---
Issue: https://github.com/tarantool/tarantool/issues/6260
Patch: https://github.com/tarantool/tarantool/tree/yshtunder/gh-6260-events-for-pub-sub
src/box/box.cc | 69 +++++-
src/box/box.h | 6 +
src/box/mp_error.cc | 6 -
src/box/raft.c | 1 +
src/lib/msgpuck | 2 +-
.../gh_6260_add_builtin_events.lua | 229 ++++++++++++++++++
test/unit/mp_error.cc | 6 -
7 files changed, 299 insertions(+), 20 deletions(-)
create mode 100644 test/app-luatest/gh_6260_add_builtin_events.lua
diff --git a/src/box/box.cc b/src/box/box.cc
index 0413cbf44..dc61dc77b 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -97,13 +97,6 @@ double txn_timeout_default;
struct rlist box_on_shutdown_trigger_list =
RLIST_HEAD_INITIALIZER(box_on_shutdown_trigger_list);
-static void title(const char *new_status)
-{
- snprintf(status, sizeof(status), "%s", new_status);
- title_set_status(new_status);
- title_update();
- systemd_snotify("STATUS=%s", status);
-}
const struct vclock *box_vclock = &replicaset.vclock;
@@ -160,6 +153,19 @@ static struct fiber_pool tx_fiber_pool;
*/
static struct cbus_endpoint tx_prio_endpoint;
+static void
+box_broadcast_status(void);
+
+static void title(const char *new_status)
+{
+ snprintf(status, sizeof(status), "%s", new_status);
+ title_set_status(new_status);
+ title_update();
+ systemd_snotify("STATUS=%s", status);
+ /* Checking box.info.status change */
+ box_broadcast_status();
+}
+
void
box_update_ro_summary(void)
{
@@ -173,6 +179,9 @@ box_update_ro_summary(void)
if (is_ro_summary)
engine_switch_to_ro();
fiber_cond_broadcast(&ro_cond);
+ /* Checking box.info.ro change */
+ box_broadcast_status();
+ box_broadcast_election();
}
const char *
@@ -3903,3 +3912,49 @@ box_reset_stat(void)
engine_reset_stat();
space_foreach(box_reset_space_stat, NULL);
}
+
+void
+box_broadcast_status(void)
+{
+ char buf[1024];
+ char *w = buf;
+
+ w = mp_encode_map(w, 3);
+ w = mp_encode_str0(w, "is_ro");
+ w = mp_encode_bool(w, box_is_ro());
+ w = mp_encode_str0(w, "is_ro_cfg");
+ w = mp_encode_bool(w, cfg_geti("read_only"));
+ w = mp_encode_str0(w, "status");
+ w = mp_encode_str0(w, box_status());
+
+ box_broadcast("box.status", strlen("box.status"), buf, w);
+
+ assert((size_t)(w - buf) < 1024);
+}
+
+void
+box_broadcast_election()
+{
+ struct raft *raft = box_raft();
+
+ char buf[1024];
+ char *w = buf;
+
+ w = mp_encode_map(w, 4);
+
+ w = mp_encode_str0(w, "term");
+ w = mp_encode_uint(w, raft->term);
+
+ w = mp_encode_str0(w, "role");
+ w = mp_encode_str0(w, raft_state_str(raft->state));
+
+ w = mp_encode_str0(w, "is_ro");
+ w = mp_encode_bool(w, box_is_ro());
+
+ w = mp_encode_str0(w, "leader");
+ w = mp_encode_uint(w, raft->leader);
+
+ box_broadcast("box.election", strlen("box.election"), buf, w);
+
+ assert((size_t)(w - buf) < 1024);
+}
diff --git a/src/box/box.h b/src/box/box.h
index b594f6646..2eb1ef437 100644
--- a/src/box/box.h
+++ b/src/box/box.h
@@ -563,6 +563,12 @@ box_process_rw(struct request *request, struct space *space,
int
boxk(int type, uint32_t space_id, const char *format, ...);
+/**
+ *
+ */
+void
+box_broadcast_election(void);
+
#if defined(__cplusplus)
} /* extern "C" */
#endif /* defined(__cplusplus) */
diff --git a/src/box/mp_error.cc b/src/box/mp_error.cc
index fba562a84..006b5f2d9 100644
--- a/src/box/mp_error.cc
+++ b/src/box/mp_error.cc
@@ -168,12 +168,6 @@ mp_sizeof_error_one(const struct error *error)
return data_size;
}
-static inline char *
-mp_encode_str0(char *data, const char *str)
-{
- return mp_encode_str(data, str, strlen(str));
-}
-
static char *
mp_encode_error_one(char *data, const struct error *error)
{
diff --git a/src/box/raft.c b/src/box/raft.c
index 1e360dc88..b2d4002fe 100644
--- a/src/box/raft.c
+++ b/src/box/raft.c
@@ -170,6 +170,7 @@ box_raft_on_update_f(struct trigger *trigger, void *event)
* writable only after it clears its synchro queue.
*/
box_update_ro_summary();
+ box_broadcast_election();
if (raft->state != RAFT_STATE_LEADER)
return 0;
/*
diff --git a/src/lib/msgpuck b/src/lib/msgpuck
index 7f95b6fd7..7f343a408 160000
--- a/src/lib/msgpuck
+++ b/src/lib/msgpuck
@@ -1 +1 @@
-Subproject commit 7f95b6fd7a5b928cfcbdab2d78bea88d1685821e
+Subproject commit 7f343a40897cbf070c897886e15eb3d761d322f4
diff --git a/test/app-luatest/gh_6260_add_builtin_events.lua b/test/app-luatest/gh_6260_add_builtin_events.lua
new file mode 100644
index 000000000..4a4e1feff
--- /dev/null
+++ b/test/app-luatest/gh_6260_add_builtin_events.lua
@@ -0,0 +1,229 @@
+local t = require('luatest')
+local net = require('net.box')
+local cluster = require('test.luatest_helpers.cluster')
+local helpers = require('test.luatest_helpers')
+
+local g = t.group('gh_6260')
+
+g.before_test('test_box_status_event', function(cg)
+ cg.cluster = cluster:new({})
+
+ local box_cfg = {
+ read_only = false
+ }
+
+ cg.master = cg.cluster:build_server({alias = 'master', box_cfg = box_cfg})
+ cg.cluster:add_server(cg.master)
+ cg.cluster:start()
+end)
+
+
+g.after_test('test_box_status_event', function(cg)
+ cg.cluster.servers = nil
+ cg.cluster:drop()
+end)
+
+
+g.test_box_status_event= function(cg)
+ local c = net.connect(cg.master.net_box_uri)
+
+ c:eval([[
+ i = ''
+ box.watch('box.status', function(...) i = {...} end)
+ ]])
+
+ t.assert_equals(c:eval("return i"),
+ {"box.status",
+ {is_ro = cg.master:eval("return box.info.ro"),
+ is_ro_cfg = cg.master:eval("return box.cfg.read_only"),
+ status = cg.master:eval("return box.info.status")}})
+
+ -- next step
+ cg.master:eval(([[
+ box.cfg{
+ replication = {
+ "%s",
+ "%s"
+ },
+ replication_connect_timeout = 0.001,
+ }
+ ]]):format(helpers.instance_uri('master'),
+ helpers.instance_uri('replica')))
+
+ t.assert_equals(c:eval("return i"),
+ {"box.status",
+ {is_ro = cg.master:eval("return box.info.ro"),
+ is_ro_cfg = cg.master:eval("return box.cfg.read_only"),
+ status = cg.master:eval("return box.info.status")}})
+
+ -- next step
+ cg.master:eval(([[
+ box.cfg{
+ replication = {
+ "%s",
+ },
+ }
+ ]]):format(helpers.instance_uri('master')))
+
+ t.assert_equals(c:eval("return i"),
+ {"box.status",
+ {is_ro = cg.master:eval("return box.info.ro"),
+ is_ro_cfg = cg.master:eval("return box.cfg.read_only"),
+ status = cg.master:eval("return box.info.status")}})
+
+ -- next step
+ cg.master:eval("box.cfg{read_only = true}")
+
+ t.assert_equals(c:eval("return i"),
+ {"box.status",
+ {is_ro = cg.master:eval("return box.info.ro"),
+ is_ro_cfg = cg.master:eval("return box.cfg.read_only"),
+ status = cg.master:eval("return box.info.status")}})
+
+
+ c:close()
+end
+
+
+g.before_test('test_box_election_event', function(cg)
+
+ cg.cluster = cluster:new({})
+
+ local box_cfg = {
+ replication = {
+ helpers.instance_uri('instance_', 1);
+ helpers.instance_uri('instance_', 2);
+ helpers.instance_uri('instance_', 3);
+ },
+ replication_connect_quorum = 0,
+ election_mode = 'candidate',
+ replication_synchro_quorum = 2,
+ replication_synchro_timeout = 1,
+ replication_timeout = 0.25,
+ election_timeout = 0.25,
+ }
+
+ cg.instance_1 = cg.cluster:build_server(
+ {alias = 'instance_1', box_cfg = box_cfg})
+
+ cg.instance_2 = cg.cluster:build_server(
+ {alias = 'instance_2', box_cfg = box_cfg})
+
+ cg.instance_3 = cg.cluster:build_server(
+ {alias = 'instance_3', box_cfg = box_cfg})
+
+ cg.cluster:add_server(cg.instance_1)
+ cg.cluster:add_server(cg.instance_2)
+ cg.cluster:add_server(cg.instance_3)
+ cg.cluster:start({cg.instance_1, cg.instance_2, cg.instance_3})
+end)
+
+
+g.after_test('test_box_election_event', function(cg)
+ cg.cluster.servers = nil
+ cg.cluster:drop({cg.instance_1, cg.instance_2, cg.instance_3})
+end)
+
+
+g.test_box_election_event= function(cg)
+ local c1 = net.connect(cg.instance_1.net_box_uri)
+ local c2 = net.connect(cg.instance_2.net_box_uri)
+ local c3 = net.connect(cg.instance_3.net_box_uri)
+
+ c1:eval([[
+ i1 = ''
+ box.watch('box.election', function(...) i1 = {...} end)
+ ]])
+ c2:eval([[
+ i2 = ''
+ box.watch('box.election', function(...) i2 = {...} end)
+ ]])
+ c3:eval([[
+ i3 = ''
+ box.watch('box.election', function(...) i3 = {...} end)
+ ]])
+
+ t.assert_equals(c1:eval("return i1"),
+ {"box.election",
+ {term = cg.instance_1:eval("return box.info.election.term"),
+ leader = cg.instance_1:eval("return box.info.election.leader"),
+ is_ro = cg.instance_1:eval("return box.info.ro"),
+ role = cg.instance_1:eval("return box.info.election.state")}})
+
+ t.assert_equals(c2:eval("return i2"),
+ {"box.election",
+ {term = cg.instance_2:eval("return box.info.election.term"),
+ leader = cg.instance_2:eval("return box.info.election.leader"),
+ is_ro = cg.instance_2:eval("return box.info.ro"),
+ role = cg.instance_2:eval("return box.info.election.state")}})
+
+ t.assert_equals(c3:eval("return i3"),
+ {"box.election",
+ {term = cg.instance_3:eval("return box.info.election.term"),
+ leader = cg.instance_3:eval("return box.info.election.leader"),
+ is_ro = cg.instance_3:eval("return box.info.ro"),
+ role = cg.instance_3:eval("return box.info.election.state")}})
+
+
+ -- next step
+ cg.instance_1:eval("return box.cfg{election_mode='voter'}")
+
+ cg.instance_1:wait_election_leader_found()
+ cg.instance_2:wait_election_leader_found()
+ cg.instance_3:wait_election_leader_found()
+
+ t.assert_equals(c1:eval("return i1"),
+ {"box.election",
+ {term = cg.instance_1:eval("return box.info.election.term"),
+ leader = cg.instance_1:eval("return box.info.election.leader"),
+ is_ro = cg.instance_1:eval("return box.info.ro"),
+ role = cg.instance_1:eval("return box.info.election.state")}})
+
+ t.assert_equals(c2:eval("return i2"),
+ {"box.election",
+ {term = cg.instance_2:eval("return box.info.election.term"),
+ leader = cg.instance_2:eval("return box.info.election.leader"),
+ is_ro = cg.instance_2:eval("return box.info.ro"),
+ role = cg.instance_2:eval("return box.info.election.state")}})
+
+ t.assert_equals(c3:eval("return i3"),
+ {"box.election",
+ {term = cg.instance_3:eval("return box.info.election.term"),
+ leader = cg.instance_3:eval("return box.info.election.leader"),
+ is_ro = cg.instance_3:eval("return box.info.ro"),
+ role = cg.instance_3:eval("return box.info.election.state")}})
+
+
+ -- next step
+ cg.instance_1:eval("return box.cfg{election_mode='candidate'}")
+ cg.instance_2:eval("return box.cfg{election_mode='voter'}")
+
+ cg.instance_1:wait_election_leader_found()
+ cg.instance_2:wait_election_leader_found()
+ cg.instance_3:wait_election_leader_found()
+
+ t.assert_equals(c1:eval("return i1"),
+ {"box.election",
+ {term = cg.instance_1:eval("return box.info.election.term"),
+ leader = cg.instance_1:eval("return box.info.election.leader"),
+ is_ro = cg.instance_1:eval("return box.info.ro"),
+ role = cg.instance_1:eval("return box.info.election.state")}})
+
+ t.assert_equals(c2:eval("return i2"),
+ {"box.election",
+ {term = cg.instance_2:eval("return box.info.election.term"),
+ leader = cg.instance_2:eval("return box.info.election.leader"),
+ is_ro = cg.instance_2:eval("return box.info.ro"),
+ role = cg.instance_2:eval("return box.info.election.state")}})
+
+ t.assert_equals(c3:eval("return i3"),
+ {"box.election",
+ {term = cg.instance_3:eval("return box.info.election.term"),
+ leader = cg.instance_3:eval("return box.info.election.leader"),
+ is_ro = cg.instance_3:eval("return box.info.ro"),
+ role = cg.instance_3:eval("return box.info.election.state")}})
+
+ c1:close()
+ c2:close()
+ c3:close()
+end
diff --git a/test/unit/mp_error.cc b/test/unit/mp_error.cc
index 5e68b34d2..5c5a323cb 100644
--- a/test/unit/mp_error.cc
+++ b/test/unit/mp_error.cc
@@ -93,12 +93,6 @@ enum {
sizeof(standard_errors) / sizeof(standard_errors[0]),
};
-static inline char *
-mp_encode_str0(char *data, const char *str)
-{
- return mp_encode_str(data, str, strlen(str));
-}
-
/** Note, not the same as mp_encode_error(). */
static char *
mp_encode_mp_error(const struct mp_test_error *e, char *data)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Tarantool-patches] [PATCH v2] net.box: add predefined system events for pub/sub
2022-01-20 4:06 [Tarantool-patches] [PATCH v2] net.box: add predefined system events for pub/sub Yan Shtunder via Tarantool-patches
@ 2022-01-27 0:23 ` Vladislav Shpilevoy via Tarantool-patches
0 siblings, 0 replies; 2+ messages in thread
From: Vladislav Shpilevoy via Tarantool-patches @ 2022-01-27 0:23 UTC (permalink / raw)
To: Yan Shtunder; +Cc: tarantool-patches
Hi! Thanks for the fixes, good job!
Please, next time watch out for which button you click - 'Reply'
or 'Reply all'. You need to keep the mailing list as one of the
receivers. Otherwise nobody else will see your responses. I paste
your response below.
Lets rebase your branch on the latest master? Your base version is
quite outdated - from 7 December 2021.
> 1. The function is never used outside of box.cc. You can make it 'static'. Also lets better call it box_broadcast_status(). It would look better if all built-in events would start with the same box_broadcast_*.
>
>
> static void
> box_broadcast_status(void);
>
> 2.
>>
>> @@ -377,9 +382,11 @@ box_set_orphan(bool orphan)
>>
>> if (is_orphan) {
>> say_crit("entering orphan mode");
>> title("orphan");
>> + box_status_broadcast();
>
> You can call this inside of title() function instead of duplicating its broadcast for each title() invocation.
>
>
> static void title(const char *new_status)
> {
> snprintf(status, sizeof(status), "%s", new_status);
> title_set_status(new_status);
> title_update();
> systemd_snotify("STATUS=%s", status);
> /* Checking box.info.status change */
> box_broadcast_status();
> }
>
> 3. Usage of non-constant values as a buffer size is not used in Tarantool code. Lets better avoid it. You can just use a big enough buffer like
> char buf[1024];
> and add an assertion in the end of encodes below that you didn't go beyond the border.
>
>
> I fixed this.
It might be easier to return to the review context if you
would keep in your response my comments together with their
context. For instance, look at your response above - we can't
see what was the context. Lets try to improve this part a
little next time, shall we?
> 4. It looks like a quite repetitive thing. mp_error.cc had the same problem and introduced mp_encode_str0(). I suggest you to make a preparatory commit which would move mp_encode_str0() from mp_error.cc into a common place from where you could reuse it.
> One option would be to make a patch for https://github.com/tarantool/msgpuck to add this new function. Or we could add it to trivia/util.h and src/util.c. The first option is better IMO.
>
>
> https://github.com/tarantool/msgpuck/commit/7f343a40897cbf070c897886e15eb3d761d322f4
Good! Now you need to send it as another patch to the mailing list.
Or as a PR to msgpuck repository. If you will use mailing list, you
can look for example of formatting such patches (not in the main
repository) in my vshard patches and luajit. The process is all the
same. You just specify the subsystem in mail title:
[Tarantool-patches] [PATCH luajit] test: adapt test checking global environment
[Tarantool-patches] [PATCH vshard 0/5] Router backoff, storage disable
Look - "luajit", "vshard" after the word PATCH. But if you feel a
bit overwhelmed, it is ok to use PRs.
> Adding predefined system event box.status and box.election
See 6 comments below.
1. It might be easier for you to split these into 2 separate commits.
With their own tests. To make the patch smaller and easier to review.
Up to you.
> Part of #6260
> ---
> Issue: https://github.com/tarantool/tarantool/issues/6260
> Patch: https://github.com/tarantool/tarantool/tree/yshtunder/gh-6260-events-for-pub-sub
>
> src/box/box.cc | 69 +++++-
> src/box/box.h | 6 +
> src/box/mp_error.cc | 6 -
> src/box/raft.c | 1 +
> src/lib/msgpuck | 2 +-
> .../gh_6260_add_builtin_events.lua | 229 ++++++++++++++++++
> test/unit/mp_error.cc | 6 -
> 7 files changed, 299 insertions(+), 20 deletions(-)
> create mode 100644 test/app-luatest/gh_6260_add_builtin_events.lua
>
> diff --git a/src/box/box.cc b/src/box/box.cc
> index 0413cbf44..dc61dc77b 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -97,13 +97,6 @@ double txn_timeout_default;
> struct rlist box_on_shutdown_trigger_list =
> RLIST_HEAD_INITIALIZER(box_on_shutdown_trigger_list);
>
> -static void title(const char *new_status)
> -{
> - snprintf(status, sizeof(status), "%s", new_status);
> - title_set_status(new_status);
> - title_update();
> - systemd_snotify("STATUS=%s", status);
> -}
>
> const struct vclock *box_vclock = &replicaset.vclock;
>
> @@ -160,6 +153,19 @@ static struct fiber_pool tx_fiber_pool;
> */
> static struct cbus_endpoint tx_prio_endpoint;
>
> +static void
> +box_broadcast_status(void);
> +
> +static void title(const char *new_status)
> +{
> + snprintf(status, sizeof(status), "%s", new_status);
> + title_set_status(new_status);
> + title_update();
> + systemd_snotify("STATUS=%s", status);
> + /* Checking box.info.status change */
> + box_broadcast_status();
> +}
2. Since you decided to move the function 'title', lets
also make it a bit cleaner - put 'static void' on a
separate line. Originally it wasn't so because the function
apparently is very old. Was added before these rules.
> +
> void
> box_update_ro_summary(void)
> {
> @@ -173,6 +179,9 @@ box_update_ro_summary(void)
> if (is_ro_summary)
> engine_switch_to_ro();
> fiber_cond_broadcast(&ro_cond);
> + /* Checking box.info.ro change */
> + box_broadcast_status();
> + box_broadcast_election();
> }
>
> const char *
> @@ -3903,3 +3912,49 @@ box_reset_stat(void)
> engine_reset_stat();
> space_foreach(box_reset_space_stat, NULL);
> }
> +
> +void
3. It should be 'static'. You never use it outside of this .cc
file.
> +box_broadcast_status(void)
> +{
> + char buf[1024];
> + char *w = buf;
> +
> + w = mp_encode_map(w, 3);
> + w = mp_encode_str0(w, "is_ro");
> + w = mp_encode_bool(w, box_is_ro());
> + w = mp_encode_str0(w, "is_ro_cfg");
> + w = mp_encode_bool(w, cfg_geti("read_only"));
> + w = mp_encode_str0(w, "status");
> + w = mp_encode_str0(w, box_status());
> +
> + box_broadcast("box.status", strlen("box.status"), buf, w);
> +
> + assert((size_t)(w - buf) < 1024);
> +}
> +
> +void
> +box_broadcast_election()
> +{
> + struct raft *raft = box_raft();
> +
> + char buf[1024];
> + char *w = buf;
> +
> + w = mp_encode_map(w, 4);
> +
> + w = mp_encode_str0(w, "term");
> + w = mp_encode_uint(w, raft->term);
> +
> + w = mp_encode_str0(w, "role");
> + w = mp_encode_str0(w, raft_state_str(raft->state));
> +
> + w = mp_encode_str0(w, "is_ro");
> + w = mp_encode_bool(w, box_is_ro());
> +
> + w = mp_encode_str0(w, "leader");
> + w = mp_encode_uint(w, raft->leader);
> +
> + box_broadcast("box.election", strlen("box.election"), buf, w);
> +
> + assert((size_t)(w - buf) < 1024);
> +}
> diff --git a/src/box/box.h b/src/box/box.h
> index b594f6646..2eb1ef437 100644
> --- a/src/box/box.h
> +++ b/src/box/box.h
> @@ -563,6 +563,12 @@ box_process_rw(struct request *request, struct space *space,
> int
> boxk(int type, uint32_t space_id, const char *format, ...);
>
> +/**
> + *
4. Please, write a proper comment here.
> + */
> +void
> +box_broadcast_election(void);
> +
> #if defined(__cplusplus)
> } /* extern "C" */
> #endif /* defined(__cplusplus) */
> diff --git a/src/box/mp_error.cc b/src/box/mp_error.cc
> index fba562a84..006b5f2d9 100644
> --- a/src/box/mp_error.cc
> +++ b/src/box/mp_error.cc
> @@ -168,12 +168,6 @@ mp_sizeof_error_one(const struct error *error)
> return data_size;
> }
>
> -static inline char *
> -mp_encode_str0(char *data, const char *str)
> -{
> - return mp_encode_str(data, str, strlen(str));
> -}
5. This should be done in a separate commit. Together with
msgpuck submodule update.
> -
> static char *
> mp_encode_error_one(char *data, const struct error *error)
> {
> diff --git a/src/box/raft.c b/src/box/raft.c
> index 1e360dc88..b2d4002fe 100644
> --- a/src/box/raft.c
> +++ b/src/box/raft.c
> @@ -170,6 +170,7 @@ box_raft_on_update_f(struct trigger *trigger, void *event)
> * writable only after it clears its synchro queue.
> */
> box_update_ro_summary();
> + box_broadcast_election();
> if (raft->state != RAFT_STATE_LEADER)
> return 0;
> /*
> diff --git a/src/lib/msgpuck b/src/lib/msgpuck
> index 7f95b6fd7..7f343a408 160000
> --- a/src/lib/msgpuck
> +++ b/src/lib/msgpuck
> @@ -1 +1 @@
> -Subproject commit 7f95b6fd7a5b928cfcbdab2d78bea88d1685821e
> +Subproject commit 7f343a40897cbf070c897886e15eb3d761d322f4
> diff --git a/test/app-luatest/gh_6260_add_builtin_events.lua b/test/app-luatest/gh_6260_add_builtin_events.lua
> new file mode 100644
> index 000000000..4a4e1feff
> --- /dev/null
> +++ b/test/app-luatest/gh_6260_add_builtin_events.lua
> @@ -0,0 +1,229 @@
> +local t = require('luatest')
> +local net = require('net.box')
> +local cluster = require('test.luatest_helpers.cluster')
> +local helpers = require('test.luatest_helpers')
> +
> +local g = t.group('gh_6260')
> +
> +g.before_test('test_box_status_event', function(cg)
> + cg.cluster = cluster:new({})
> +
> + local box_cfg = {
> + read_only = false
> + }
> +
> + cg.master = cg.cluster:build_server({alias = 'master', box_cfg = box_cfg})
> + cg.cluster:add_server(cg.master)
> + cg.cluster:start()
> +end)
> +
> +
> +g.after_test('test_box_status_event', function(cg)
> + cg.cluster.servers = nil
> + cg.cluster:drop()
> +end)
> +
> +
> +g.test_box_status_event= function(cg)
> + local c = net.connect(cg.master.net_box_uri)
> +
> + c:eval([[
> + i = ''
> + box.watch('box.status', function(...) i = {...} end)
> + ]])
6. Sorry, it seems there was a misunderstanding. When I meant we need
netbox tests, I meant of netbox subscriptions. You did the same as in v1:
you used eval to test box.watch locally on the storages.
What I would want you to do is to test `c:watch()`. Netbox connections
have the same subscription API as box.
box.watch() should be tested too, but we shouldn't ignore
`connection:watch()`. Usage of events by remote clients like netbox is
the main motivation of subscriptions.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-27 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-20 4:06 [Tarantool-patches] [PATCH v2] net.box: add predefined system events for pub/sub Yan Shtunder via Tarantool-patches
2022-01-27 0:23 ` Vladislav Shpilevoy via Tarantool-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox