From: Vladimir Davydov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Serge Petrenko via Tarantool-patches
<tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test
Date: Wed, 8 Dec 2021 14:25:54 +0300 [thread overview]
Message-ID: <20211208112554.xdyltiuxuqfzqu4x@esperanza> (raw)
In-Reply-To: <5169d323-4c8f-d7d2-3344-32fcad5c2d5d@tarantool.org>
On Wed, Dec 08, 2021 at 02:13:04PM +0300, Serge Petrenko wrote:
>
>
> 08.12.2021 14:00, Vladimir Davydov via Tarantool-patches пишет:
> > Merged into master, 2.8, 1.10.
> >
> > Please don't send emails. PR is enough :-)
>
> Some people prefer emails over PRs.
>
> I think everyone should review the patches where it suits
> them best, so I open PRs for you and send emails to Vlad.
> (even though this is double the hustle).
This is confusing. I noticed the email only after I merged the PR.
In the PR, I was the only reviewer so I reckoned it's okay to merge,
but it turned out the patch was also sent to Vlad via email...
Also, when the same patch is reviewed both via email and PR, the same
comment might be raised twice by different reviewers or reviewers may
suggest different things being not aware of each other's arguments and
you'll have to reconcile.
Vlad can review patches in PRs AFAICS - he reviews my patches in PRs,
for instance.
next prev parent reply other threads:[~2021-12-08 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 10:44 Serge Petrenko via Tarantool-patches
2021-12-08 11:00 ` Vladimir Davydov via Tarantool-patches
2021-12-08 11:13 ` Serge Petrenko via Tarantool-patches
2021-12-08 11:25 ` Vladimir Davydov via Tarantool-patches [this message]
2021-12-08 11:56 ` Serge Petrenko via Tarantool-patches
2021-12-08 23:45 ` Vladislav Shpilevoy via Tarantool-patches
2021-12-09 10:19 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208112554.xdyltiuxuqfzqu4x@esperanza \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3160-misc... test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox