Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Lord <kashkin.nsaa@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] sql: Update POSITION() tests
Date: Thu, 2 Dec 2021 13:35:17 +0300	[thread overview]
Message-ID: <20211202103517.GA21659@tarantool.org> (raw)
In-Reply-To: <20211121214122.103443-1-lord.nemo@protonmail.com>

Hi! Thank you for the patch! See 5 comments below.

1. Please add a hyperlink to the branch and a hyperlink to the issue when
submitting the patch. Or you can use PR. Better to use PR as your branch will
be checked out in CI.

2. Why do you need these changes? How are these changes related to the KMP?

2. Tests 1.0.1 and 1.0.3 are similar to 1.13, 1.0.5 is similar to 1.9 and 1.0.6
is similar to 1.8. Tests 1.0.2 and 1.0.4 have something new, but you can simply
add them to the end of the file. The same about changes in tests 1.63-1.65 -
you can add new tests at the end of the file instead of changing old tests.

3. Please use do_execsql_test() instead of do_test(...execsql()...).

On Mon, Nov 22, 2021 at 12:41:22AM +0300, Lord via Tarantool-patches wrote:
> diff --git a/test/sql-tap/position.test.lua b/test/sql-tap/position.test.lua
> index 6a96ed9bc..d35f00122 100755
> --- a/test/sql-tap/position.test.lua
> +++ b/test/sql-tap/position.test.lua
> @@ -1,6 +1,66 @@
>  #!/usr/bin/env tarantool
>  local test = require("sqltester")
> -test:plan(80)
> +test:plan(86)
> +
> +test:do_test(
> +    "position-1.0.1",
> +    function()
> +        return test:execsql "SELECT position('ststs', 'statemenstrststs');"
4. Please use parentheses after execsql(). Here and below.

> +test:do_execsql_test(           --TODO
5. What about this '--TODO'? Why do you need to change this test?

      reply	other threads:[~2021-12-02 10:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-21 21:41 Lord via Tarantool-patches
2021-12-02 10:35 ` Mergen Imeev via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211202103517.GA21659@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kashkin.nsaa@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH] sql: Update POSITION() tests' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox