From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6411C70152; Thu, 2 Dec 2021 13:35:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6411C70152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1638441320; bh=kU+7X961EsuzJi61yNbpzrN6RvHYszzJLqS/zou1ofA=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bYMv/KvdgUVccQy8CEMD7oIfqd7JVjxL7ZO6kb7zi0gcAPERnTJTnyoXbqFfgC73g rUquGEzqGb33N0S308HeV7h9EpLHLQhsHq6HuX+EGxbFcbKqdxAP6JOhhtqaQf/FHi MhloJSHB1jL0b67Urr2FoM/hG+A1K9wKDDClus5Q= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6811470152 for ; Thu, 2 Dec 2021 13:35:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6811470152 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1msjQs-000125-TY; Thu, 02 Dec 2021 13:35:19 +0300 Date: Thu, 2 Dec 2021 13:35:17 +0300 To: Lord Cc: tarantool-patches@dev.tarantool.org Message-ID: <20211202103517.GA21659@tarantool.org> References: <20211121214122.103443-1-lord.nemo@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211121214122.103443-1-lord.nemo@protonmail.com> X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD93822B471089FF64DFA455658C3104DE9BDD9AB7435BCB66C182A05F53808504014CAEC894119EDDBA871496D59B9520069F4551095193D3E46641F46264939F5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745C0EDBD94D46193EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371005780D56A98C20EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2C05FD9399956BBBCEFE4113CB2EC8FFCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9F5955FECEF5819E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A56CF169187C0388D0B7D6D8E5DBE860931A7FA1A3B12910A5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759F66ED85EB5F25FD410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D50AEDB859DBAD9E753BBE5BCA7DAFFF963CE06ED277E87BA2DE327DB3FDAF45E33C403775159A71D7E09C32AA3244C8FEA49DF31E92E5B4EA63C8907C4D4B79CA7333006C390A0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMMFVqzO9sR0GpErei5tzTg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D06A76209F288E888FF0888EB956A7EB883D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] sql: Update POSITION() tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patch! See 5 comments below. 1. Please add a hyperlink to the branch and a hyperlink to the issue when submitting the patch. Or you can use PR. Better to use PR as your branch will be checked out in CI. 2. Why do you need these changes? How are these changes related to the KMP? 2. Tests 1.0.1 and 1.0.3 are similar to 1.13, 1.0.5 is similar to 1.9 and 1.0.6 is similar to 1.8. Tests 1.0.2 and 1.0.4 have something new, but you can simply add them to the end of the file. The same about changes in tests 1.63-1.65 - you can add new tests at the end of the file instead of changing old tests. 3. Please use do_execsql_test() instead of do_test(...execsql()...). On Mon, Nov 22, 2021 at 12:41:22AM +0300, Lord via Tarantool-patches wrote: > diff --git a/test/sql-tap/position.test.lua b/test/sql-tap/position.test.lua > index 6a96ed9bc..d35f00122 100755 > --- a/test/sql-tap/position.test.lua > +++ b/test/sql-tap/position.test.lua > @@ -1,6 +1,66 @@ > #!/usr/bin/env tarantool > local test = require("sqltester") > -test:plan(80) > +test:plan(86) > + > +test:do_test( > + "position-1.0.1", > + function() > + return test:execsql "SELECT position('ststs', 'statemenstrststs');" 4. Please use parentheses after execsql(). Here and below. > +test:do_execsql_test( --TODO 5. What about this '--TODO'? Why do you need to change this test?