Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] tuple: make tuple_bless() compilable
Date: Mon, 8 Nov 2021 12:35:04 +0000	[thread overview]
Message-ID: <20211108123503.GA7532@tarantool.org> (raw)
In-Reply-To: <20211027110640.GA8831@tarantool.org>

On 27 Oct 14:06, Igor Munkin wrote:
> > +    -- lower frame". So avoid tail call and use additional stack
> > +    -- slots (for the local variable and the frame).
> > +    local tuple_ref = ffi.gc(ffi.cast(const_tuple_ref_t, tuple), tuple_gc)
> > +    return tuple_ref
> Side note: Ugh... I'm sad we're doing things like this one. Complicating
> the code, leaving huge comments with the rationale of such complicating
> to reach the desirable (and what is important, local) performance. I
> propose to spend your innovative time to try solving the problem in the
> JIT engine: it will be more fun and allow us to avoid writing the
> cookbook "How to write super-duper-jittable code in LuaJIT".
> Here is the valid question: what about other hot places with CALLT in
> Tarantool? Should they be considered/fixed? I guess a ticket will help
> to not forget about this problem.
> Anyway, for now the fix provides the considerable boost, so feel free to
> proceed with the patch.

Said today exactly the same:) LGTM as well.

  parent reply	other threads:[~2021-11-08 12:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 13:02 Sergey Kaplun via Tarantool-patches
2021-10-27 11:06 ` Igor Munkin via Tarantool-patches
2021-10-27 13:16   ` Sergey Kaplun via Tarantool-patches
2021-11-08 12:35   ` Nikita Pettik via Tarantool-patches [this message]
2021-11-10 12:31 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211108123503.GA7532@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=korablev@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] tuple: make tuple_bless() compilable' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox