From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6EE8E6F3E5; Mon, 8 Nov 2021 15:35:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EE8E6F3E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1636374907; bh=1IcS+GQOFU4p9FfLuFJ4FAhGFzZVdv5kJV2e8zb/Az8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aye1o8ZuxW65b8pY8vQJG1s+Bs407e6DSc37FVAXqOg4Srb094okcfJjaX1kftrmI A4g/OwSS7AXehLLob6HbjGmHLubJRUZGQnpPyYCq2Mhtbvjb6QQDR89ezwQ9iYdliA JFIdp0Nxy6f/H4c8VoHkBzYLomx+fvFZUUnG5VRg= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD3316F3E5 for ; Mon, 8 Nov 2021 15:35:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD3316F3E5 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1mk3rc-0005PR-Pw; Mon, 08 Nov 2021 15:35:05 +0300 Date: Mon, 8 Nov 2021 12:35:04 +0000 To: Igor Munkin Message-ID: <20211108123503.GA7532@tarantool.org> References: <20211022130225.6076-1-skaplun@tarantool.org> <20211027110640.GA8831@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211027110640.GA8831@tarantool.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9731B3922EC063979FDDC2AE24248DB216D6453DBFA9511E900894C459B0CD1B9037381B9017818902C79395F523AA4E877E140D65BDCE318AEBB3C0239580454 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D31CF4E13A5F8DDAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373880C950E4B364568638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89980E591527A1372DF00B741779BF3E4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C8C83961949B2167BC0837EA9F3D197644AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C31E02C1345990865276E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C64E4DC1543031AB7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A512A114F019AC2C5A130C7271D0D473CBADE00D830E49BDD0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341E08D7EE1804B7634876F75C5F407586D1273D449B14A20CFAFF33C533FD5AA11AB0E2C63F13262A1D7E09C32AA3244C681C6F6754ABBCDE0F680E5A257AB993E8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj9/1IdNVT2RZXtyv5vxsqJw== X-Mailru-Sender: 5E616C0FE969A709BC2841F6A3283ABFEC472DB265949732CE040D163B094EC023B38D4FA7FB5885DDAB76DE2EFCC57FE67C000C8395E179911E6ECAD2435D151D139210CB918485112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] tuple: make tuple_bless() compilable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nikita Pettik via Tarantool-patches Reply-To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 27 Oct 14:06, Igor Munkin wrote: > > + -- lower frame". So avoid tail call and use additional stack > > + -- slots (for the local variable and the frame). > > + local tuple_ref = ffi.gc(ffi.cast(const_tuple_ref_t, tuple), tuple_gc) > > + return tuple_ref > > Side note: Ugh... I'm sad we're doing things like this one. Complicating > the code, leaving huge comments with the rationale of such complicating > to reach the desirable (and what is important, local) performance. I > propose to spend your innovative time to try solving the problem in the > JIT engine: it will be more fun and allow us to avoid writing the > cookbook "How to write super-duper-jittable code in LuaJIT". > > Here is the valid question: what about other hot places with CALLT in > Tarantool? Should they be considered/fixed? I guess a ticket will help > to not forget about this problem. > > Anyway, for now the fix provides the considerable boost, so feel free to > proceed with the patch. Said today exactly the same:) LGTM as well.