From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Mikhail Shishatskiy <m.shishatskiy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v4 2/4] memprof: refactor location parsing Date: Wed, 27 Oct 2021 16:56:27 +0300 [thread overview] Message-ID: <20211027135627.GC8831@tarantool.org> (raw) In-Reply-To: <20210929200758.149446-3-m.shishatskiy@tarantool.org> Misha, Thanks for the patch! Everything is fine in general, but consider a few nits below, please. On 29.09.21, Mikhail Shishatskiy wrote: > As it is hard to keep function `id_location` easily usable in the > function `parse_location` with a growing number of fields in the > <loc> table, the code is refactored to make it more understandable. > > The API of <utils/symtab.lua> module changed with adding a function > `id(loc)` returning the same id-string, as `id_location` did. This > function is useful to "stringify" the location and use it as a key > in the key/value storage. It's worth to also mention that the function need to be used in other modules, hence you've made it public in symtab.lua. > > Part of tarantool/tarantool#5814 > --- > > Issue: https://github.com/tarantool/tarantool/issues/5814 > Branch: https://github.com/tarantool/luajit/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number > CI: https://github.com/tarantool/tarantool/tree/shishqa/gh-5814-group-allocations-on-trace-by-trace-number > > tools/memprof/parse.lua | 26 +++++++++++++------------- > tools/utils/symtab.lua | 4 ++++ > 2 files changed, 17 insertions(+), 13 deletions(-) > > diff --git a/tools/memprof/parse.lua b/tools/memprof/parse.lua > index 12e2758f..34ff8aef 100644 > --- a/tools/memprof/parse.lua > +++ b/tools/memprof/parse.lua > @@ -8,6 +8,8 @@ local bit = require "bit" > local band = bit.band > local lshift = bit.lshift > > +local symtab = require "utils.symtab" Minor: Why here? It's better either to group all <requires> in the one place (worse, IMHO) or just add a new <require> just prior to the part with constants i.e. below <string.format> caching (better, IMHO). > + > local string_format = string.format > > local LJM_MAGIC = "ljm" > @@ -59,22 +61,20 @@ local function link_to_previous(heap_chunk, e, nsize) > end > end > > -local function id_location(addr, line) > - return string_format("f%#xl%d", addr, line), { > - addr = addr, > - line = line, > - } > -end > - > local function parse_location(reader, asource) > - if asource == ASOURCE_INT then > - return id_location(0, 0) > - elseif asource == ASOURCE_CFUNC then > - return id_location(reader:read_uleb128(), 0) > + local loc = { > + addr = 0, > + line = 0, > + } > + if asource == ASOURCE_CFUNC then > + loc.addr = reader:read_uleb128() > elseif asource == ASOURCE_LFUNC then > - return id_location(reader:read_uleb128(), reader:read_uleb128()) > + loc.addr = reader:read_uleb128() > + loc.line = reader:read_uleb128() > + elseif asource ~= ASOURCE_INT then Minor: It's better to write a separate condition for <ASOURCE_INT> and a separate block for so-called "default" (i.e. plain "else" block) with an error. So it looks kinda the following: | if asource == ASOURCE_INT then | -- Do nothing. Add a suppression for luacheck here. | elseif asource == ASOURCE_CFUNC then | loc.addr = reader:read_uleb128() | elseif asource == ASOURCE_LFUNC then | loc.addr = reader:read_uleb128() | loc.line = reader:read_uleb128() | else | error("Unknown asource "..asource) | end If you were confused by luacheck, don't worry: just add a suppression for this block. > + error("Unknown asource "..asource) > end > - error("Unknown asource "..asource) > + return symtab.id(loc), loc > end > > local function parse_alloc(reader, asource, events, heap) <snipped> > > -- > 2.33.0 > -- Best regards, IM
next prev parent reply other threads:[~2021-10-27 13:56 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-20 7:05 [Tarantool-patches] [PATCH luajit v3 0/4] memprof: group allocations on traces by trace number Mikhail Shishatskiy via Tarantool-patches 2021-08-20 7:05 ` [Tarantool-patches] [PATCH luajit v3 1/5] core: add const to lj_debug_line proto parameter Mikhail Shishatskiy via Tarantool-patches 2021-09-16 15:29 ` Igor Munkin via Tarantool-patches 2021-08-20 7:05 ` [Tarantool-patches] [PATCH luajit v3 2/5] test: separate memprof Lua API tests into subtests Mikhail Shishatskiy via Tarantool-patches 2021-09-16 15:29 ` Igor Munkin via Tarantool-patches 2021-08-20 7:05 ` [Tarantool-patches] [PATCH luajit v3 3/5] memprof: dump traceno if allocate from trace Mikhail Shishatskiy via Tarantool-patches 2021-09-16 15:32 ` Igor Munkin via Tarantool-patches 2021-09-29 19:21 ` Mikhail Shishatskiy via Tarantool-patches 2021-08-20 7:05 ` [Tarantool-patches] [PATCH luajit v3 4/5] memprof: extend symtab with info about traces Mikhail Shishatskiy via Tarantool-patches 2021-09-16 15:32 ` Igor Munkin via Tarantool-patches 2021-09-29 19:21 ` Mikhail Shishatskiy via Tarantool-patches 2021-08-20 7:05 ` [Tarantool-patches] [PATCH luajit v3 5/5] luajit: change order of modules Mikhail Shishatskiy via Tarantool-patches 2021-09-16 15:32 ` Igor Munkin via Tarantool-patches 2021-09-29 20:07 ` [Tarantool-patches] [PATCH luajit v4 0/4] memprof: group allocations on traces by traceno Mikhail Shishatskiy via Tarantool-patches 2021-09-29 20:07 ` [Tarantool-patches] [PATCH luajit v4 1/4] test: separate memprof Lua API tests into subtests Mikhail Shishatskiy via Tarantool-patches 2021-10-27 13:56 ` Igor Munkin via Tarantool-patches 2021-10-27 15:07 ` Sergey Kaplun via Tarantool-patches 2021-09-29 20:07 ` [Tarantool-patches] [PATCH luajit v4 2/4] memprof: refactor location parsing Mikhail Shishatskiy via Tarantool-patches 2021-10-27 13:56 ` Igor Munkin via Tarantool-patches [this message] [not found] ` <20211104130010.mcvnra6e4yl5moo2@surf.localdomain> 2021-11-10 15:38 ` Igor Munkin via Tarantool-patches 2021-09-29 20:07 ` [Tarantool-patches] [PATCH luajit v4 3/4] memprof: group allocations on traces by traceno Mikhail Shishatskiy via Tarantool-patches 2021-10-27 13:56 ` Igor Munkin via Tarantool-patches [not found] ` <20211104130156.f2botlihlfhwd3yh@surf.localdomain> 2021-11-11 15:34 ` Igor Munkin via Tarantool-patches 2021-09-29 20:07 ` [Tarantool-patches] [PATCH luajit v4 4/4] memprof: add info about trace start to symtab Mikhail Shishatskiy via Tarantool-patches 2021-11-01 16:31 ` Igor Munkin via Tarantool-patches [not found] ` <20211104130228.x6qcne5xeh544hm7@surf.localdomain> 2021-11-12 13:34 ` Igor Munkin via Tarantool-patches 2021-11-17 8:17 ` Sergey Kaplun via Tarantool-patches 2021-11-22 15:11 ` Mikhail Shishatskiy via Tarantool-patches 2021-11-24 12:42 ` Mikhail Shishatskiy via Tarantool-patches 2021-11-24 16:44 ` Igor Munkin via Tarantool-patches 2022-01-27 23:29 ` [Tarantool-patches] [PATCH luajit v4 0/4] memprof: group allocations on traces by traceno Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211027135627.GC8831@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.shishatskiy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v4 2/4] memprof: refactor location parsing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox