From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v23 0/3] qsync: implement packet filtering (part 1)
Date: Fri, 15 Oct 2021 00:56:19 +0300 [thread overview]
Message-ID: <20211014215622.49732-1-gorcunov@gmail.com> (raw)
Guys, please take a look once time permit, any comments are highly appreciated!
Serge, here are some important changes:
- as being discussed verbally about limbo owner test I think most straight
forward solution is to allow nesting txn_limbo_is_owner calls
- in test I left the snippet
| -- Finally enable election_replica3 back. Make sure the data from new election_replica2
| -- leader get writing while old leader's data ignored.
| test_run:switch("election_replica3")
| box.error.injection.set('ERRINJ_WAL_DELAY', false)
| test_run:wait_cond(function() return box.space.test:get{2} ~= nil end)
| box.space.test:select{}
untouched because final select{} does test for needed results so I don't need
to count writes
The tests are passed locally but lets wait for complete CI results.
v22 (by SergeP):
- use limbo emptiness test _after_ owner_id test
- drop redundant assert in limbo commit/rollback
since we're unlocking a latch anyway where own
assertion present
- in test: drop excessive wait_cond and setup wal
delay earlier
v23 (by SergeP):
- fix problem with owner test in case of recovery journal
- update test
branch gorcunov/gh-6036-rollback-confirm-23
issue https://github.com/tarantool/tarantool/issues/6036
previous series https://lists.tarantool.org/tarantool-patches/20211011191635.573685-1-gorcunov@gmail.com/
Cyrill Gorcunov (3):
latch: add latch_is_locked helper
qsync: order access to the limbo terms
test: add gh-6036-qsync-order test
src/box/applier.cc | 12 +-
src/box/box.cc | 15 +-
src/box/relay.cc | 11 +-
src/box/txn.c | 2 +-
src/box/txn_limbo.c | 49 ++++-
src/box/txn_limbo.h | 87 +++++++-
src/lib/core/latch.h | 11 +
test/replication/gh-6036-qsync-order.result | 190 ++++++++++++++++++
test/replication/gh-6036-qsync-order.test.lua | 93 +++++++++
test/replication/suite.cfg | 1 +
test/replication/suite.ini | 2 +-
test/unit/snap_quorum_delay.cc | 5 +-
12 files changed, 447 insertions(+), 31 deletions(-)
create mode 100644 test/replication/gh-6036-qsync-order.result
create mode 100644 test/replication/gh-6036-qsync-order.test.lua
base-commit: 4bca48611d7ae772ea095181349194c0c31f9a9b
--
2.31.1
next reply other threads:[~2021-10-14 21:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 21:56 Cyrill Gorcunov via Tarantool-patches [this message]
2021-10-14 21:56 ` [Tarantool-patches] [PATCH v23 1/3] latch: add latch_is_locked helper Cyrill Gorcunov via Tarantool-patches
2021-10-14 21:56 ` [Tarantool-patches] [PATCH v23 2/3] qsync: order access to the limbo terms Cyrill Gorcunov via Tarantool-patches
2021-10-21 22:06 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-14 21:56 ` [Tarantool-patches] [PATCH v23 3/3] test: add gh-6036-qsync-order test Cyrill Gorcunov via Tarantool-patches
2021-10-19 15:09 ` Serge Petrenko via Tarantool-patches
2021-10-19 22:26 ` Cyrill Gorcunov via Tarantool-patches
2021-10-20 6:35 ` Serge Petrenko via Tarantool-patches
2021-10-21 22:06 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-22 6:36 ` Serge Petrenko via Tarantool-patches
2021-10-21 22:06 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-22 22:03 ` Cyrill Gorcunov via Tarantool-patches
2021-10-24 15:39 ` Vladislav Shpilevoy via Tarantool-patches
2021-10-24 16:01 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014215622.49732-1-gorcunov@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH v23 0/3] qsync: implement packet filtering (part 1)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox