Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: fix comparison between DECIMAL and big DOUBLE
Date: Tue, 7 Sep 2021 14:40:25 +0300
Message-ID: <20210907114025.GX5743@tarantool.org> (raw)
In-Reply-To: <6229320676324201d74e78ac1f2832b79fd159cb.1630303937.git.imeevma@gmail.com>

Mergen,

Thanks for the patch! LGTM, with a few nits regarding the commit
message.

On 30.08.21, Mergen Imeev via Tarantool-patches wrote:
> This patch fixes comparison between DECIMAL value and DOUBLE values
> greater or equal to 1e38 or less or equal to -1e38. Now any DOUBLE value
> greater or equal to 1e38 is more than any DECIMAL value and DOUBLE
> value less or equal to -1e38 is less than any DECIMAL value.

Minor: Considering Vlad's review[1], I would explicitly mention the
order of the operands to be compared (DECIMAL is the left one, DOUBLE is
the right one). The opposite case works fine even prior to the patch.

Minor: It would be clearer, if you mention here that there are only 38
decimal digits in DECIMAL representation (hence, 1e38).

> 
> Closes #6376
> ---
> https://github.com/tarantool/tarantool/issues/6376
> https://github.com/tarantool/tarantool/tree/imeevma/gh-6376-fix-cmp-between-big-double-and-dec
> 
>  .../gh-6376-fix-incorrect-dec-inf-cmp.md      |  3 ++
>  src/box/sql/mem.c                             |  4 +-
>  test/sql-tap/engine.cfg                       |  1 +
>  .../gh-6376-wrong-double-to-dec-cmp.test.lua  | 38 +++++++++++++++++++
>  4 files changed, 44 insertions(+), 2 deletions(-)
>  create mode 100644 changelogs/unreleased/gh-6376-fix-incorrect-dec-inf-cmp.md
>  create mode 100755 test/sql-tap/gh-6376-wrong-double-to-dec-cmp.test.lua
> 

<snipped>

> -- 
> 2.25.1
> 

[1]: https://lists.tarantool.org/tarantool-patches/003f11f0-5ecc-2e69-dc89-47a34b5f24ac@tarantool.org/

-- 
Best regards,
IM

  parent reply	other threads:[~2021-09-07 12:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  6:13 Mergen Imeev via Tarantool-patches
2021-08-31 19:46 ` Timur Safin via Tarantool-patches
2021-09-01  8:52   ` Mergen Imeev via Tarantool-patches
2021-09-07  9:28     ` Safin Timur via Tarantool-patches
2021-09-07 11:26       ` Igor Munkin via Tarantool-patches
2021-09-07 11:40 ` Igor Munkin via Tarantool-patches [this message]
2021-09-09  7:39   ` Mergen Imeev via Tarantool-patches
2021-09-09 10:24 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907114025.GX5743@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=imun@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git