Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: fix comparison between DECIMAL and big DOUBLE
Date: Thu, 9 Sep 2021 10:24:47 +0000
Message-ID: <20210909102447.dklo5cowyga4xa4f@tarantool.org> (raw)
In-Reply-To: <6229320676324201d74e78ac1f2832b79fd159cb.1630303937.git.imeevma@gmail.com>

Hello,

On 30 авг 09:13, Mergen Imeev via Tarantool-patches wrote:
> This patch fixes comparison between DECIMAL value and DOUBLE values
> greater or equal to 1e38 or less or equal to -1e38. Now any DOUBLE value
> greater or equal to 1e38 is more than any DECIMAL value and DOUBLE
> value less or equal to -1e38 is less than any DECIMAL value.
> 
> Closes #6376
> ---
> https://github.com/tarantool/tarantool/issues/6376
> https://github.com/tarantool/tarantool/tree/imeevma/gh-6376-fix-cmp-between-big-double-and-dec

I've checked your patch into master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-09-09 10:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  6:13 Mergen Imeev via Tarantool-patches
2021-08-31 19:46 ` Timur Safin via Tarantool-patches
2021-09-01  8:52   ` Mergen Imeev via Tarantool-patches
2021-09-07  9:28     ` Safin Timur via Tarantool-patches
2021-09-07 11:26       ` Igor Munkin via Tarantool-patches
2021-09-07 11:40 ` Igor Munkin via Tarantool-patches
2021-09-09  7:39   ` Mergen Imeev via Tarantool-patches
2021-09-09 10:24 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210909102447.dklo5cowyga4xa4f@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kyukhin@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git