From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix exit stub patching. Date: Thu, 19 Aug 2021 10:15:51 +0300 [thread overview] Message-ID: <20210819071551.GN5743@tarantool.org> (raw) In-Reply-To: <20210819073332.w2qdsgoti5kq4krm@tarantool.org> Kirill, Thanks for your review! On 19.08.21, Kirill Yukhin wrote: > Hello, > > On 18 авг 22:51, Igor Munkin wrote: > > From: Mike Pall <mike> > > > > Contributed by Javier Guerra Giraldez. > > > > (cherry picked from commit 9da06535092d6d9dec442641a26c64bce5574322) > > > > When the side trace is assembled, it is linked to its parent trace. For > > this purpose, JIT runs through the parent trace mcode and updates jump > > instruction targeted to the corresponding exitno. Prior to this patch, > > these instructions were patched unconditionally, that leads to errors if > > the jump target address is out of the value ranges specified in ARM64 > > references[1][2][3][4][5][6]. > > > > As a result of the patch <lj_asm_patchexit> considers value ranges of > > the jump targets and updates directly only those instructions fitting > > the particular jump range. Moreover, the corresponding jump in the pad > > leading to <lj_vm_exit_handler> is also patched, so those instructions, > > that are not updated before, targets to the linked side trace too. > > > > Additionaly, there is some refactoring of jump targets assembling in > > scope of this patch. > > > > Igor Munkin: > > * added the description and the test for the problem > > > > [1]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B > > [2]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B-cond > > [3]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBZ > > [4]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBNZ > > [5]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBZ > > [6]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBNZ > > > > Resoves tarantool/tarantool#6098 > > Part of tarantool/tarantool#5629 > > LGTM. Added your tag: | Reviewed-by: Kirill Yukhin <kyukhin@tarantool.org> > > -- > Regards, Kirill Yukhin -- Best regards, IM
next prev parent reply other threads:[~2021-08-19 7:41 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-18 19:51 Igor Munkin via Tarantool-patches 2021-08-18 20:51 ` Igor Munkin via Tarantool-patches 2021-08-19 6:01 ` Sergey Kaplun via Tarantool-patches 2021-08-19 6:07 ` Igor Munkin via Tarantool-patches 2021-08-19 7:33 ` Kirill Yukhin via Tarantool-patches 2021-08-19 7:15 ` Igor Munkin via Tarantool-patches [this message] 2021-08-19 8:24 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210819071551.GN5743@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=kyukhin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix exit stub patching.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox