From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 01F406EC40; Thu, 19 Aug 2021 10:41:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 01F406EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629358864; bh=VZeIBAa6jLm8fFzrHg4JCK1LfqHQzBaaCvJga9NYukc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jSgEOmwIKAa78rcqAj4sGv+3FOwuUsMGRtyUlgZdCn757bbfaUImHiBmbOQZFE4MW UcF4+muYBLeAsWhJ/JgrHFtn2LjChy57WkSOYAl2SNcbRzrLBuYHWXK7/5nHzzjmsS eOpCcypTuC/MazcSzDTq/a4b73LXwBnWOJe2LS9Q= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3CE316EC40 for ; Thu, 19 Aug 2021 10:41:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3CE316EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mGcfd-0003BV-PT; Thu, 19 Aug 2021 10:41:02 +0300 Date: Thu, 19 Aug 2021 10:15:51 +0300 To: Kirill Yukhin Message-ID: <20210819071551.GN5743@tarantool.org> References: <3c9433a3166bcc2396efb01e89261dea370bd5c1.1629315033.git.imun@tarantool.org> <20210819073332.w2qdsgoti5kq4krm@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210819073332.w2qdsgoti5kq4krm@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD910164DC12A5633065676A9727AC27C74182A05F538085040BE8740EF9E8F35782A11B659D18C9003DD6879E0788D10654EADC763D1100D38 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BA0D57D3459E5640EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063775FF68B4B43662428638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86DB2FFF99294377CCB50B3036B055904117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BC6A536F79815AD9275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5A27AC635EE8F80E4C480572C01DC06CCD5FEDAA43CD5AC72D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758B25CD4253D1D611410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA13E2DDB90678628B96B151BB27AC5E6BCABF4C657C767A1D7D3525820AE1AC3C7F3651B1B569D81D7E09C32AA3244C91691EA8AC99ECF86FD72292C0FA03A5F165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBHb8i4Q3xMukA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D2A80907BB1B74FBD03F331956E011AE0A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Fix exit stub patching. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Kirill, Thanks for your review! On 19.08.21, Kirill Yukhin wrote: > Hello, > > On 18 авг 22:51, Igor Munkin wrote: > > From: Mike Pall > > > > Contributed by Javier Guerra Giraldez. > > > > (cherry picked from commit 9da06535092d6d9dec442641a26c64bce5574322) > > > > When the side trace is assembled, it is linked to its parent trace. For > > this purpose, JIT runs through the parent trace mcode and updates jump > > instruction targeted to the corresponding exitno. Prior to this patch, > > these instructions were patched unconditionally, that leads to errors if > > the jump target address is out of the value ranges specified in ARM64 > > references[1][2][3][4][5][6]. > > > > As a result of the patch considers value ranges of > > the jump targets and updates directly only those instructions fitting > > the particular jump range. Moreover, the corresponding jump in the pad > > leading to is also patched, so those instructions, > > that are not updated before, targets to the linked side trace too. > > > > Additionaly, there is some refactoring of jump targets assembling in > > scope of this patch. > > > > Igor Munkin: > > * added the description and the test for the problem > > > > [1]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B > > [2]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/B-cond > > [3]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBZ > > [4]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/CBNZ > > [5]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBZ > > [6]: https://developer.arm.com/documentation/dui0801/g/A64-General-Instructions/TBNZ > > > > Resoves tarantool/tarantool#6098 > > Part of tarantool/tarantool#5629 > > LGTM. Added your tag: | Reviewed-by: Kirill Yukhin > > -- > Regards, Kirill Yukhin -- Best regards, IM