Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Yan Shtunder <ya.shtunder@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: fill replicaset.applier.vclock after local recovery
Date: Wed, 11 Aug 2021 06:17:29 +0000	[thread overview]
Message-ID: <20210811061729.snfajyci5iormybb@tarantool.org> (raw)
In-Reply-To: <20210809100931.14367-1-ya.shtunder@gmail.com>

Hello,

On 09 авг 13:09, Yan Shtunder via Tarantool-patches wrote:
> replicaset.applier.vclock is initialized in replication_init(),
> which happens before local recovery. If some changes are come
> frome some instance via applier that applier.vclock will equal 0.
> This means that if some wild master send this node already applied
> data, the node will apply the same data twice.
> 
> Closes #6028
> ---
> Issue: https://github.com/tarantool/tarantool/issues/6028
> Patch: https://github.com/tarantool/tarantool/tree/yshtunder/gh-6028-applier-vclock

I've checked your patch into 2.7, 2.8 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-08-11  6:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 10:09 Yan Shtunder via Tarantool-patches
2021-08-09 13:04 ` Sergey Ostanevich via Tarantool-patches
2021-08-09 13:11 ` Serge Petrenko via Tarantool-patches
2021-08-10 12:19   ` Vitaliia Ioffe via Tarantool-patches
2021-08-11  6:17 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811061729.snfajyci5iormybb@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=ya.shtunder@gmail.com \
    --subject='Re: [Tarantool-patches] [PATCH] replication: fill replicaset.applier.vclock after local recovery' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox