From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 92AC26EC40; Wed, 11 Aug 2021 09:17:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 92AC26EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628662651; bh=82rBpkhbF8TrSnU8cuJm+oUSgbijlDUD9Ku+y/9v/yg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=adTLCN9BI+F+rePHAqDsmsUvw8b9s/5/X1Qm3ibhGe7CgiuiCs24zQpBfjuDdPAco wLXdVDFGS3G5Z1aW6QhJUmV/NKGs7LJ9eaYBZ2QWQQWvy9yjYLm3oYVPmRDhvtliou ldG9db7DhWkJj9LeqgUcFvM3DP+rVx806HQ5vipA= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CBD5A6EC40 for ; Wed, 11 Aug 2021 09:17:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CBD5A6EC40 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1mDhYQ-0006o2-3X; Wed, 11 Aug 2021 09:17:30 +0300 Date: Wed, 11 Aug 2021 06:17:29 +0000 To: Yan Shtunder Message-ID: <20210811061729.snfajyci5iormybb@tarantool.org> References: <20210809100931.14367-1-ya.shtunder@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210809100931.14367-1-ya.shtunder@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F56291F8739A291D6182A05F53808504006898276EA8547A74AD30BF6A6115D28B5B9E69BDD90D0CB863C1C4AD7FB7602 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FEAC828D2BF6EC3CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BFC71155C4C95E1B5C6F56DADAD45F44117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC80A9EC8C3488E7643F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C68E4D7E803FA7AD59735652A29929C6C4AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3712029526DC6922FBA3038C0950A5D36B5C8C57E37DE458B1F384C11F87108AA6D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE74ABCC139FF3F849B731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505EBE5044C126477F7343F16A7722FC62A X-C1DE0DAB: 0D63561A33F958A5C9A757A43251BF99A1E3A2805EA33979D33CC1E6B310BF45D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753177526CD55AFC11410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342B1F2AD168155B066801A15C7EF3155EEAC8ECB0D981EA95F60D24EDE69E3E8A457B2DE662D5699A1D7E09C32AA3244C5B32F1B7291CA7294413F747D4850E3130452B15D76AEC14927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6qlzQV0oSZNK0EI2tSUfZg== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD28BD86DA29F98B55BBE17BFA0AD13734AA8103BFB463E903ECA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] replication: fill replicaset.applier.vclock after local recovery X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 09 авг 13:09, Yan Shtunder via Tarantool-patches wrote: > replicaset.applier.vclock is initialized in replication_init(), > which happens before local recovery. If some changes are come > frome some instance via applier that applier.vclock will equal 0. > This means that if some wild master send this node already applied > data, the node will apply the same data twice. > > Closes #6028 > --- > Issue: https://github.com/tarantool/tarantool/issues/6028 > Patch: https://github.com/tarantool/tarantool/tree/yshtunder/gh-6028-applier-vclock I've checked your patch into 2.7, 2.8 and master. -- Regards, Kirill Yukhin