From: Vladimir Davydov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: mechanik20051988 <mechanik20051988@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org,
mechanik20051988 <mechanik20.05.1988@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 1/7] iproto: implement stream id in binary iproto protocol
Date: Fri, 6 Aug 2021 11:20:53 +0300 [thread overview]
Message-ID: <20210806082053.4hcurxeuewqwnh53@esperanza> (raw)
In-Reply-To: <7f1a921ef966fa619fb8bf1bda9f94d7f9c06c10.1628184138.git.mechanik20.05.1988@gmail.com>
On Thu, Aug 05, 2021 at 09:17:39PM +0300, mechanik20051988 wrote:
> From: mechanik20051988 <mechanik20.05.1988@gmail.com>
>
> For further implementation of streams, we need to separate
> requests belonging to and not belonging to streams. For this
> purpose, the stream ID field was added to the iproto binary
> protocol. For requests that do not belong to stream, this field
> is omitted or equal to zero. For requests belonging to stream,
> we use this field to determine which stream the request belongs to.
>
> Part of #5860
>
> @TarantoolBot document
> Title: new field in binary iproto protocol
>
> Add new field to binary iproto protocol.
> `IPROTO_STREAM_ID 0x0a` determines whether a request
> belongs to a stream or not. If this field is omited
> or equal to zero this request doesn't belongs to stream.
> ---
> src/box/iproto_constants.c | 4 +-
> src/box/iproto_constants.h | 1 +
> src/box/xrow.c | 8 ++
> src/box/xrow.h | 5 ++
> test/unit/xrow.cc | 7 +-
> test/unit/xrow.result | 168 +++++++++++++++++++------------------
> 6 files changed, 109 insertions(+), 84 deletions(-)
LGTM
next prev parent reply other threads:[~2021-08-06 8:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 18:17 [Tarantool-patches] [PATCH 0/7] implement iproto streams mechanik20051988 via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 1/7] iproto: implement stream id in binary iproto protocol mechanik20051988 via Tarantool-patches
2021-08-06 8:20 ` Vladimir Davydov via Tarantool-patches [this message]
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 2/7] salad: fix segfault in case when mhash table allocation failure mechanik20051988 via Tarantool-patches
2021-08-06 8:33 ` Vladimir Davydov via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 3/7] txn: detach transaction from fiber mechanik20051988 via Tarantool-patches
2021-08-06 8:51 ` Vladimir Davydov via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 4/7] iproto: implement streams in iproto mechanik20051988 via Tarantool-patches
2021-08-06 10:30 ` Vladimir Davydov via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 5/7] net.box: add stream support to net.box mechanik20051988 via Tarantool-patches
2021-08-06 12:03 ` Vladimir Davydov via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 6/7] iproto: implement interactive transactions over iproto streams mechanik20051988 via Tarantool-patches
2021-08-06 12:59 ` Vladimir Davydov via Tarantool-patches
2021-08-09 10:39 ` Vladimir Davydov via Tarantool-patches
2021-08-09 10:40 ` [Tarantool-patches] [PATCH 1/2] xrow: remove unused call_request::header Vladimir Davydov via Tarantool-patches
2021-08-09 10:40 ` [Tarantool-patches] [PATCH 2/2] iproto: clear request::header for client requests Vladimir Davydov via Tarantool-patches
2021-08-09 11:27 ` Evgeny Mekhanik via Tarantool-patches
2021-08-09 11:26 ` [Tarantool-patches] [PATCH 1/2] xrow: remove unused call_request::header Evgeny Mekhanik via Tarantool-patches
2021-08-05 18:17 ` [Tarantool-patches] [PATCH 7/7] net.box: add interactive transaction support in net.box mechanik20051988 via Tarantool-patches
2021-08-06 14:04 ` Vladimir Davydov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806082053.4hcurxeuewqwnh53@esperanza \
--to=tarantool-patches@dev.tarantool.org \
--cc=mechanik20.05.1988@gmail.com \
--cc=mechanik20051988@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/7] iproto: implement stream id in binary iproto protocol' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox