Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: fix cast of small negative DOUBLE to INTEGER
Date: Wed, 4 Aug 2021 14:02:42 +0000	[thread overview]
Message-ID: <20210804140242.nissydow44xnzsfk@tarantool.org> (raw)
In-Reply-To: <56566984f956da0d7532011b8670c18c92a3facc.1628065405.git.imeevma@gmail.com>


On 04 авг 11:24, imeevma@tarantool.org wrote:
> Prior to this patch when DOUBLE value that less than 0.0 and greater
> than -1.0 was cast to INTEGER, it was considered to be negative number
> though the result was 0. This patch fixes this, so now such DOUBLE
> value will be properly cast to INTEGER and UNSIGNED.
> Closes #6225
> ---
> https://github.com/tarantool/tarantool/issues/6225
> https://github.com/tarantool/tarantool/tree/imeevma/gh-6225-cast-of-small-negative-double-to-int

The patch LGTM.

Regards, Kirill Yukhin

  reply	other threads:[~2021-08-04 14:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  8:24 Mergen Imeev via Tarantool-patches
2021-08-04 14:02 ` Kirill Yukhin via Tarantool-patches [this message]
2021-08-04 15:07   ` Vitaliia Ioffe via Tarantool-patches
2021-08-05  9:36 ` Kirill Yukhin via Tarantool-patches
  -- strict thread matches above, loose matches on Subject: below --
2021-08-02 17:04 Mergen Imeev via Tarantool-patches
2021-07-29  6:45 Mergen Imeev via Tarantool-patches
2021-07-21 15:07 Mergen Imeev via Tarantool-patches
2021-07-26 19:47 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-27  8:09   ` Mergen Imeev via Tarantool-patches
2021-07-28 21:55     ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804140242.nissydow44xnzsfk@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: fix cast of small negative DOUBLE to INTEGER' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox