From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 05AFF6EC58; Wed, 4 Aug 2021 17:02:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 05AFF6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628085765; bh=OYEjYaQOv61yYoDrUNmKHPJJPZIEk8WjECCdL0/5y9k=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=e+Z6WI3kIUFzeDBuu7Q9Yz3IdJcxz8AG+1qnviRUv+QQv23duxg9tQmBMouAUwTdc OQeaj7HC0JJEkt9oUlNugfWqw4XNJZVhbDYOfqAk47cwb4ZjIwS/6OQmmtfxq7uZOY 0MS95XZ+xzsHzx3UTGt81wBtlkA6P0SUl1+hqS1w= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 83D686EC58 for ; Wed, 4 Aug 2021 17:02:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 83D686EC58 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1mBHTm-0007sS-Q8; Wed, 04 Aug 2021 17:02:43 +0300 Date: Wed, 4 Aug 2021 14:02:42 +0000 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210804140242.nissydow44xnzsfk@tarantool.org> References: <56566984f956da0d7532011b8670c18c92a3facc.1628065405.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56566984f956da0d7532011b8670c18c92a3facc.1628065405.git.imeevma@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C33D83595CA30D6DC5179D1C9A908C47E5182A05F538085040E8AF3238705141A1130D609212EC706283000B3D15AA6956E1124361EC1BCF6B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70312E9A300D47E3BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D64EDD178B2A1008638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89298308CC36E68CBF2DDFC07C6C3561A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FE03CEA74F0D118906D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE31E44367C8E80A7B4AD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377F02F59195295693EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5E16DC078803A9FE1AC198D71B8E7D749A2F294533477D419D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34697E0FA301E2821506926EA932F0EDC0634224F9C7E189B5F01C73D1132F0DF39D4FD0891048FC9B1D7E09C32AA3244C9A983AA650E13598E4140F5A513DE80B3C6EB905E3A8056B729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJFs2bVqPbNesQ== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD267500DC9B413A428804EE08EE711E8A1818686BA13EDE563CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: fix cast of small negative DOUBLE to INTEGER X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 04 авг 11:24, imeevma@tarantool.org wrote: > Prior to this patch when DOUBLE value that less than 0.0 and greater > than -1.0 was cast to INTEGER, it was considered to be negative number > though the result was 0. This patch fixes this, so now such DOUBLE > value will be properly cast to INTEGER and UNSIGNED. > > Closes #6225 > --- > https://github.com/tarantool/tarantool/issues/6225 > https://github.com/tarantool/tarantool/tree/imeevma/gh-6225-cast-of-small-negative-double-to-int The patch LGTM. -- Regards, Kirill Yukhin