Re: [Tarantool-patches] [PATCH v2 00/10] test: lua-Harness suite patch bump

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Max,

Thanks for the series! Please consider the comments I left for each
patch. Besides, to differ the patches for tarantool/tarantool repo from
the patches for tarantool/luajit repo, please use 'luajit' in subject
prefix when formatting the patch (consider this patch[1] as an example).

On 20.07.21, Maxim Kokryashkin wrote:
> As our experience has been considered by the maintainer of lua-Harness
> and the issues we faced are finally fixed in mainline repo, we should
> bump lua-Harness suite up to c4451fe0.
> 
> Part of tarantool/tarantool#5970
> Part of tarantool/tarantool#4473
> 
> ---
> Changes in v2:
>   - Fixed comments as per review by Igor Munkin <imun@tarantool.org>
>   - Backported two more fixes from trunk
>   - Disabled 241-standalone.t as it is facing some issues to run 
>     properly on FreeBSD (for more information see
>     tarantool/tarantool#6231)
> 
> Github branch: 
> https://github.com/tarantool/luajit/tree/fckxorg/gh-5970-update-lua-harness
> 
> Issue:
> https://github.com/tarantool/tarantool/issues/5970
> 
> Tests: passing

It's more convenient to share the commit that triggered Tarantool CI. In
your case this is https://github.com/tarantool/tarantool/commit/344c18d.

> 
> 
> Maxim Kokryashkin (10):
>   test: port lua-Harness to Test.Assertion
>   test: rename lua-Harness tap to test_assertion
>   test: use CI friendly variables in lua-Harness
>   test: refactor with _retrieve_progname
>   test: refactor with _dofile
>   test: support tarantool in lua-Harness
>   test: backport lua-Harness directory detection
>   test: support tarantool cli in lua-Harness
>   test: update lua-Harness to b7b1a9a2
>   test: disable test/lua-Harness-tests/241-standalone.t on FreeBSD
> 
>  test/lua-Harness-tests/090-tap.t              |  10 +-
>  test/lua-Harness-tests/091-profile.t          |  12 +-
>  test/lua-Harness-tests/101-boolean.t          | 130 +--
>  test/lua-Harness-tests/102-function.t         | 222 +++---
>  test/lua-Harness-tests/103-nil.t              | 130 +--
>  test/lua-Harness-tests/104-number.t           | 274 +++----
>  test/lua-Harness-tests/105-string.t           | 312 ++++----
>  test/lua-Harness-tests/106-table.t            | 136 ++--
>  test/lua-Harness-tests/107-thread.t           | 132 +--
>  test/lua-Harness-tests/108-userdata.t         | 128 +--
>  test/lua-Harness-tests/200-examples.t         |  16 +-
>  test/lua-Harness-tests/201-assign.t           |  84 +-
>  test/lua-Harness-tests/202-expr.t             | 140 ++--
>  test/lua-Harness-tests/203-lexico.t           |  78 +-
>  test/lua-Harness-tests/204-grammar.t          |  78 +-
>  test/lua-Harness-tests/211-scope.t            |  26 +-
>  test/lua-Harness-tests/212-function.t         | 140 ++--
>  test/lua-Harness-tests/213-closure.t          |  34 +-
>  test/lua-Harness-tests/214-coroutine.t        |  98 +--
>  test/lua-Harness-tests/221-table.t            |  56 +-
>  test/lua-Harness-tests/222-constructor.t      |  36 +-
>  test/lua-Harness-tests/223-iterator.t         |  20 +-
>  test/lua-Harness-tests/231-metatable.t        | 236 +++---
>  test/lua-Harness-tests/232-object.t           |  40 +-
>  test/lua-Harness-tests/241-standalone.t       | 330 ++++++++
>  .../241-standalone.t.disabled                 | 269 -------
>  test/lua-Harness-tests/242-luac.t             |  88 +-
>  test/lua-Harness-tests/301-basic.t            | 754 +++++++++---------
>  test/lua-Harness-tests/303-package.t          | 125 +--
>  test/lua-Harness-tests/304-string.t           | 650 +++++++--------
>  test/lua-Harness-tests/305-utf8.t             |  10 +-
>  test/lua-Harness-tests/306-table.t            | 188 ++---
>  test/lua-Harness-tests/307-math.t             | 268 +++----
>  test/lua-Harness-tests/308-io.t               | 252 +++---
>  test/lua-Harness-tests/309-os.t               | 164 ++--
>  test/lua-Harness-tests/310-debug.t            | 230 +++---
>  test/lua-Harness-tests/311-bit32.t            |  72 +-
>  test/lua-Harness-tests/314-regex.t            |  12 +-
>  test/lua-Harness-tests/320-stdin.t            |  40 +-
>  test/lua-Harness-tests/401-bitop.t            |  64 +-
>  test/lua-Harness-tests/402-ffi.t              |  82 +-
>  test/lua-Harness-tests/403-jit.t              | 100 +--
>  test/lua-Harness-tests/404-ext.t              | 168 ++--
>  test/lua-Harness-tests/411-luajit.t           | 211 +++++
>  test/lua-Harness-tests/411-luajit.t.disabled  | 211 -----
>  test/lua-Harness-tests/CMakeLists.txt         |   5 -
>  test/lua-Harness-tests/lexico52/lexico.t      |  22 +-
>  test/lua-Harness-tests/lexico53/boolean.t     |  44 +-
>  test/lua-Harness-tests/lexico53/function.t    |  72 +-
>  test/lua-Harness-tests/lexico53/lexico.t      |  14 +-
>  test/lua-Harness-tests/lexico53/nil.t         |  44 +-
>  test/lua-Harness-tests/lexico53/number.t      | 224 +++---
>  test/lua-Harness-tests/lexico53/string.t      | 196 ++---
>  test/lua-Harness-tests/lexico53/table.t       |  44 +-
>  test/lua-Harness-tests/lexico53/thread.t      |  44 +-
>  test/lua-Harness-tests/lexico53/userdata.t    |  44 +-
>  test/lua-Harness-tests/lexico53/utf8.t        | 240 +++---
>  test/lua-Harness-tests/lexico54/lexico.t      |   8 +-
>  test/lua-Harness-tests/lexico54/metatable.t   |  14 +-
>  test/lua-Harness-tests/lexico54/utf8.t        |  34 +-
>  test/lua-Harness-tests/lexicojit/basic.t      |  14 +-
>  test/lua-Harness-tests/lexicojit/ext.t        |  26 +-
>  test/lua-Harness-tests/lexicojit/lexico.t     |  30 +-
>  test/lua-Harness-tests/profile_ravi.lua       |   4 +-
>  test/lua-Harness-tests/profile_tarantool.lua  |  63 ++
>  .../{tap.lua => test_assertion.lua}           | 133 +--
>  test/luajit-test-init.lua                     |   2 +
>  67 files changed, 4165 insertions(+), 4012 deletions(-)
>  create mode 100755 test/lua-Harness-tests/241-standalone.t
>  delete mode 100755 test/lua-Harness-tests/241-standalone.t.disabled
>  create mode 100755 test/lua-Harness-tests/411-luajit.t
>  delete mode 100755 test/lua-Harness-tests/411-luajit.t.disabled
>  create mode 100644 test/lua-Harness-tests/profile_tarantool.lua
>  rename test/lua-Harness-tests/{tap.lua => test_assertion.lua} (58%)
> 
> -- 
> 2.32.0
> 

[1]: https://lists.tarantool.org/tarantool-patches/5fdb4899061156f0fb4c53027d55f93be3a24759.1627144350.git.imun@tarantool.org/T/#u

-- 
Best regards,
IM