Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mikhail Shishatskiy <m.shishatskiy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] gdb: fix misalignment in lj-stack for LJ_GC64
Date: Wed, 7 Jul 2021 21:35:49 +0300	[thread overview]
Message-ID: <20210707183549.GF11494@tarantool.org> (raw)
In-Reply-To: <20210707071046.649107-1-m.shishatskiy@tarantool.org>


Thanks for the new patch! It LGTM, but I have two side notes for the
further series.

1. This is the second attempt to fix #5876. Hence, as it is mentioned in
our guidelines[1], in addition to 'luajit' prefix, you need to add 'v2'
prefix too for the convenience.
2. Do not forget adding the issue link the same way you do for the
remote branch.

These are not critical nits, but such minor "whistles" make maintainer's
life better!

[1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/

Best regards,

  reply	other threads:[~2021-07-07 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  7:10 Mikhail Shishatskiy via Tarantool-patches
2021-07-07 18:35 ` Igor Munkin via Tarantool-patches [this message]
2021-07-22 13:35 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210707183549.GF11494@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.shishatskiy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] gdb: fix misalignment in lj-stack for LJ_GC64' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox