From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5BFD16EC40; Wed, 7 Jul 2021 21:59:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5BFD16EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625684364; bh=Fza6HCEBS4PWixZIsNmJbgx8UyIkYolh5o/PtzpSwXo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cMfzILZMlV3XUYcsel7s3R73NvhPbj7iTuQzTKh+cq1n19qsOz2X64ZA3Jcj0kArj /un+n56E2F49trFH9jgUSokxAewLrPUPFrOo2xkRY0WCANTUNv0+nkgqLZaDDTHzZL TqgVXUvTyc3Q85ZmHSFILtMzxeE69LzEtqfR0c+Q= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A112F6EC40 for ; Wed, 7 Jul 2021 21:59:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A112F6EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1m1ClU-0001cV-Gq; Wed, 07 Jul 2021 21:59:20 +0300 Date: Wed, 7 Jul 2021 21:35:49 +0300 To: Mikhail Shishatskiy Message-ID: <20210707183549.GF11494@tarantool.org> References: <20210707071046.649107-1-m.shishatskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210707071046.649107-1-m.shishatskiy@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB96E19CC2B9345E2B1F8975EC27617E56182A05F5380850409F53C02B66C4AA9A204EE0334909AA0CDFA2B2D3E8A9EC8553EC6A03E5A79945 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE704BA85F3D5A9F85BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C5BAFDCCAC60DA968638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EE173D22E7115D8DA57E1EBC04170E92117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5682B64521BB610FB26FD46E76099F7CD7DEC41D665009C46D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341ADA1A41A420E9B2F7F1E59F79E7CE91A6F6C62DF82B67790F3A8DCE4C7B0D10A75F861F9AD060A21D7E09C32AA3244C03DD66744E9A59E00826EA062435F06C435BF7150578642F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn2mVJJV7Q04kA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D686809CEEBEB70CE8F710C7935A29266A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] gdb: fix misalignment in lj-stack for LJ_GC64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Misha, Thanks for the new patch! It LGTM, but I have two side notes for the further series. 1. This is the second attempt to fix #5876. Hence, as it is mentioned in our guidelines[1], in addition to 'luajit' prefix, you need to add 'v2' prefix too for the convenience. 2. Do not forget adding the issue link the same way you do for the remote branch. These are not critical nits, but such minor "whistles" make maintainer's life better! [1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/ -- Best regards, IM