From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] sql: introduce SQL built-in function UUID()
Date: Mon, 31 May 2021 13:21:53 +0300 [thread overview]
Message-ID: <20210531102153.GA104557@tarantool.org> (raw)
In-Reply-To: <3c145311-aa2c-b606-84e3-bb5234bbf603@tarantool.org>
Hi! Thank toy for the review! I moved changelod from first patch to second and
expanded it a bit. Diffs below.
On Fri, May 28, 2021 at 10:51:26PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> You need to add a changelog about UUID() function. You can
> probably join it with the changelog about UUID type.
Diff for first patch:
diff --git a/changelogs/unreleased/introduce-uuid-to-sql.md b/changelogs/unreleased/introduce-uuid-to-sql.md
deleted file mode 100644
index 120fb145a..000000000
--- a/changelogs/unreleased/introduce-uuid-to-sql.md
+++ /dev/null
@@ -1,3 +0,0 @@
-## feature/core
-
- * Field type UUID is now available in SQL (gh-5886).
Diff for second patch:
diff --git a/changelogs/unreleased/introduce-uuid-to-sql.md b/changelogs/unreleased/introduce-uuid-to-sql.md
new file mode 100644
index 000000000..642ac94fb
--- /dev/null
+++ b/changelogs/unreleased/introduce-uuid-to-sql.md
@@ -0,0 +1,3 @@
+## feature/core
+
+ * Field type UUID is now available in SQL, and new UUID can be generated using new SQL built-in function uuid() (gh-5886).
next prev parent reply other threads:[~2021-05-31 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 16:43 [Tarantool-patches] [PATCH 0/2] sql: introduce UUID Mergen Imeev via Tarantool-patches
2021-05-27 16:43 ` [Tarantool-patches] [PATCH 1/2] sql: introduce UUID field type Mergen Imeev via Tarantool-patches
2021-05-27 16:43 ` [Tarantool-patches] [PATCH 2/2] sql: introduce SQL built-in function UUID() Mergen Imeev via Tarantool-patches
2021-05-28 9:52 ` Mergen Imeev via Tarantool-patches
2021-05-28 20:51 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-31 10:21 ` Mergen Imeev via Tarantool-patches [this message]
2021-06-01 21:53 ` [Tarantool-patches] [PATCH 0/2] sql: introduce UUID Vladislav Shpilevoy via Tarantool-patches
2021-06-07 10:51 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531102153.GA104557@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] sql: introduce SQL built-in function UUID()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox