From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels
Date: Thu, 27 May 2021 01:04:54 +0300 [thread overview]
Message-ID: <20210526220454.twurat7647tcx4be@tkn_work_nb> (raw)
In-Reply-To: <20210507111305.564935-1-gorcunov@gmail.com>
Sorry for the late response.
Looks nice! LGTM.
If you'll have a free time, it would be good to add a simple test case:
just to automatically verify it for regressions in a future.
WBR, Alexander Turenko.
On Fri, May 07, 2021 at 02:13:05PM +0300, Cyrill Gorcunov wrote:
> Currently `log` module accepts only numeric values of
> logging levels. I turn `box.cfg` interface supports
> symbolic names (such as 'fatal', 'crit' and etc).
>
> Thus we should support the same in `log` module.
>
> Closes #5882
>
> Reported-by: Alexander Turenko <alexander.turenko@tarantool.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> issue https://github.com/tarantool/tarantool/issues/5882
> branch gorcunov/gh-5882-logger-strings
>
> <...>
next prev parent reply other threads:[~2021-05-26 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:13 Cyrill Gorcunov via Tarantool-patches
2021-05-07 11:17 ` Cyrill Gorcunov via Tarantool-patches
2021-05-26 11:04 ` Serge Petrenko via Tarantool-patches
2021-05-26 22:04 ` Alexander Turenko via Tarantool-patches [this message]
2021-05-27 7:53 ` Cyrill Gorcunov via Tarantool-patches
2021-05-27 9:04 ` Alexander Turenko via Tarantool-patches
2021-05-27 10:17 ` Cyrill Gorcunov via Tarantool-patches
2021-06-01 12:25 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526220454.twurat7647tcx4be@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH] lua/log: accept symbolic logging levels' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox