Re: [Tarantool-patches] [PATCH] test_run:wait_log - drop redundant assert

[Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sorry for the late response.

LGTM. Thank you!

I resend it as [1] to don't push into master silently: our QA team
should know about changes in test-run.

I added a couple of words how it appears that the unnecessary assert is
placed here.

[1]: https://github.com/tarantool/test-run/pull/306

WBR, Alexander Turenko.

On Thu, Mar 25, 2021 at 04:29:33PM +0300, Cyrill Gorcunov wrote:
> The callee wait_cond does setup timeout by self in case if not provided
> 
>  | local function wait_cond(self, cond, timeout, delay)
>  |     ...
>  |     local timeout = timeout or 60
>  |     ...
>  | end
>  |
>  | local function wait_log(self, node, what, bytes, timeout, opts)
>  |     ...
>  |     return wait_cond(self, cond, timeout, delay)
>  | end
> 
> so no need to verify if timeout is provided in wait_log args.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  test_run.lua | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test_run.lua b/test_run.lua
> index 5c29ec9..9e95402 100644
> --- a/test_run.lua
> +++ b/test_run.lua
> @@ -426,7 +426,6 @@ end
>  -- Wrapper for grep_log, wait until expected log entry is appear
>  -- in a server log file.
>  local function wait_log(self, node, what, bytes, timeout, opts)
> -    assert(timeout ~= nil)
>  
>      local opts = opts or {}
>      local delay = opts.delay
> -- 
> 2.30.2
>