From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: avtikhon <avtikhon@gmail.com>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 3/6] Rename replicas to the each test specified name
Date: Thu, 27 May 2021 00:02:45 +0300 [thread overview]
Message-ID: <20210526210245.upsctq7fiqc6cpwl@tkn_work_nb> (raw)
In-Reply-To: <33fd4391bbebf99c39921e1927f79d798b2f4b19.1554127720.git.avtikhon@gmail.com>
On Mon, Apr 01, 2019 at 05:13:32PM +0300, avtikhon wrote:
> From: avtikhon <avtikhon@gmail.com>
>
> ---
> test/replication/before_replace.lua | 37 +++++
> test/replication/before_replace.result | 44 +++---
> test/replication/before_replace.test.lua | 44 +++---
> test/replication/before_replace1.lua | 1 +
> test/replication/before_replace2.lua | 1 +
> test/replication/before_replace3.lua | 1 +
> test/replication/catch.result | 22 +--
> test/replication/catch.test.lua | 22 +--
> test/replication/ddl.lua | 4 +-
> test/replication/errinj.result | 70 +++++-----
> test/replication/errinj.test.lua | 70 +++++-----
> test/replication/force_recovery.result | 16 +--
> test/replication/force_recovery.test.lua | 16 +--
> test/replication/gc.result | 49 +++----
> test/replication/gc.test.lua | 38 +++--
> test/replication/gc_no_space.result | 22 +--
> test/replication/gc_no_space.test.lua | 22 +--
> test/replication/hot_standby.result | 22 +--
> test/replication/hot_standby.test.lua | 22 +--
> test/replication/join_vclock.result | 9 +-
> test/replication/join_vclock.test.lua | 8 +-
> test/replication/local_spaces.result | 18 +--
> test/replication/local_spaces.test.lua | 18 +--
> test/replication/lua/fast_replica.lua | 125 +++++++++++++----
> test/replication/misc.lua | 37 +++++
> test/replication/misc.result | 132 +++++++++---------
> test/replication/misc.test.lua | 132 +++++++++---------
> test/replication/misc1.lua | 1 +
> test/replication/misc2.lua | 1 +
> test/replication/misc3.lua | 1 +
> test/replication/on_replace.result | 14 +-
> test/replication/on_replace.test.lua | 14 +-
> test/replication/prune.result | 38 ++---
> test/replication/prune.test.lua | 35 ++---
> test/replication/quorum.result | 32 ++---
> test/replication/quorum.test.lua | 32 ++---
> test/replication/recover_missing_xlog.lua | 37 +++++
> test/replication/recover_missing_xlog.result | 18 ++-
> .../replication/recover_missing_xlog.test.lua | 18 ++-
> test/replication/recover_missing_xlog1.lua | 1 +
> test/replication/recover_missing_xlog2.lua | 1 +
> test/replication/recover_missing_xlog3.lua | 1 +
> test/replication/replica_rejoin.result | 52 +++----
> test/replication/replica_rejoin.test.lua | 52 +++----
> test/replication/replica_uuid_ro1.lua | 1 -
> test/replication/replica_uuid_ro2.lua | 1 -
> test/replication/replica_uuid_ro3.lua | 1 -
> ...a_uuid_ro.lua => replicaset_ro_mostly.lua} | 6 +-
> test/replication/replicaset_ro_mostly.result | 6 +-
> .../replication/replicaset_ro_mostly.test.lua | 6 +-
> test/replication/replicaset_ro_mostly1.lua | 1 +
> test/replication/replicaset_ro_mostly2.lua | 1 +
> test/replication/replicaset_ro_mostly3.lua | 1 +
> test/replication/show_error_on_disconnect.lua | 38 +++++
> .../show_error_on_disconnect.result | 12 +-
> .../show_error_on_disconnect.test.lua | 12 +-
> .../replication/show_error_on_disconnect1.lua | 1 +
> .../replication/show_error_on_disconnect2.lua | 1 +
> .../replication/show_error_on_disconnect3.lua | 1 +
> test/replication/skip_conflict_row.result | 36 ++---
> test/replication/skip_conflict_row.test.lua | 36 ++---
> test/replication/status.result | 24 ++--
> test/replication/status.test.lua | 24 ++--
> test/replication/sync.result | 28 ++--
> test/replication/sync.test.lua | 28 ++--
> test/replication/wal_rw_stress.result | 22 +--
> test/replication/wal_rw_stress.test.lua | 22 +--
> 67 files changed, 938 insertions(+), 721 deletions(-)
> create mode 100644 test/replication/before_replace.lua
> create mode 120000 test/replication/before_replace1.lua
> create mode 120000 test/replication/before_replace2.lua
> create mode 120000 test/replication/before_replace3.lua
> create mode 100644 test/replication/misc.lua
> create mode 120000 test/replication/misc1.lua
> create mode 120000 test/replication/misc2.lua
> create mode 120000 test/replication/misc3.lua
> create mode 100644 test/replication/recover_missing_xlog.lua
> create mode 120000 test/replication/recover_missing_xlog1.lua
> create mode 120000 test/replication/recover_missing_xlog2.lua
> create mode 120000 test/replication/recover_missing_xlog3.lua
> delete mode 120000 test/replication/replica_uuid_ro1.lua
> delete mode 120000 test/replication/replica_uuid_ro2.lua
> delete mode 120000 test/replication/replica_uuid_ro3.lua
> rename test/replication/{replica_uuid_ro.lua => replicaset_ro_mostly.lua} (83%)
> create mode 120000 test/replication/replicaset_ro_mostly1.lua
> create mode 120000 test/replication/replicaset_ro_mostly2.lua
> create mode 120000 test/replication/replicaset_ro_mostly3.lua
> create mode 100644 test/replication/show_error_on_disconnect.lua
> create mode 120000 test/replication/show_error_on_disconnect1.lua
> create mode 120000 test/replication/show_error_on_disconnect2.lua
> create mode 120000 test/replication/show_error_on_disconnect3.lua
<..stripped the diff itself..>
(Sorry for the late response.)
I understood your idea, but I would prefer to write an instance script
as part of a test.
See my thoughts in https://github.com/tarantool/test-run/issues/305
And I would not rewrite everything at once. I think it is better to
refactor a test, when you're working on it. At this point you have all
aspects in the head and can achieve the best result for given piece of
code (it is not so, when you're doing a bulk update).
WBR, Alexander Turenko.
next prev parent reply other threads:[~2021-05-26 21:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 14:13 [tarantool-patches] [PATCH v1 1/6] Update the timeouts, set to use the default value avtikhon
2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 2/6] Insert status calls inside wait_cond routines avtikhon
2019-04-10 12:26 ` [tarantool-patches] " Alexander Turenko
2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 3/6] Rename replicas to the each test specified name avtikhon
2021-05-26 21:02 ` Alexander Turenko via Tarantool-patches [this message]
2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 4/6] Removed unused variable avtikhon
2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 5/6] Test misc tunning avtikhon
2019-04-10 12:29 ` [tarantool-patches] " Alexander Turenko
2019-04-01 14:13 ` [tarantool-patches] [PATCH v1 6/6] Fix wait_fullmesh avtikhon
2019-04-10 12:32 ` [tarantool-patches] Re: [PATCH v1 1/6] Update the timeouts, set to use the default value Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526210245.upsctq7fiqc6cpwl@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@gmail.com \
--cc=avtikhon@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 3/6] Rename replicas to the each test specified name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox