From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 88C226EC58; Thu, 27 May 2021 00:02:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 88C226EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622062971; bh=8mz/tYOZCU3Ykg/aGqsHF9vuHx+o+ajxEPV+WChNmtI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cVvkGTkhd8c3Rp2QdWS9LT12wJjty+cIOYsYQTe+bNOc1Zp/GmHEAQPKINXB9OdUE YiErwdxv/arrlexb2+3iExsCAtSjZy0d4V+Vowf6s5HaIuNzTx4oulddXFCgkbFhCa Bi48jrk5pO18po2S3ygANRD4h5AE+UsU0fHRVq0E= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A05DE6EC58 for ; Thu, 27 May 2021 00:02:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A05DE6EC58 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lm0fx-00007H-PQ; Thu, 27 May 2021 00:02:50 +0300 Date: Thu, 27 May 2021 00:02:45 +0300 To: "Alexander V. Tikhonov" Cc: avtikhon , tarantool-patches@dev.tarantool.org Message-ID: <20210526210245.upsctq7fiqc6cpwl@tkn_work_nb> References: <33fd4391bbebf99c39921e1927f79d798b2f4b19.1554127720.git.avtikhon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <33fd4391bbebf99c39921e1927f79d798b2f4b19.1554127720.git.avtikhon@gmail.com> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9157EECD0FDB90B9ACAD49BB81F6138BA3FF1437BFDE6218300894C459B0CD1B94B036617355F73E9270FEE72A3BB4449000D51E93056FB94A4B6E33E76DF1710 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DD81BB19E5DE3F6B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D851AC77095F1918C74D1CFBA4D7B6EEBC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCE2A68AC901FE7BE8D81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE7A87E5801AFC99F00EC76A7562686271EEC990983EF5C03292E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3DB8B71E42BA00C4F35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADE45409D4D0AA00EBC9073FDA8DB96817 X-C1DE0DAB: 0D63561A33F958A571ADB2E641FC85A49E87F2272DCF8FE1D10CA246F793836CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75E3127721F5A72C97410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F8A2DF183797A6A8C568EB4F30735823986F84DB8660FBA2F19A55B1F8C5584FA83F513261DA91EB1D7E09C32AA3244C4D0DE9A1D17E9873CA051EAC1389EB9E3FD9C8CA1B0515E0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiWl9RlzdedmDETlRO/oKKQ== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE4B036617355F73E9270FEE72A3BB4449B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 3/6] Rename replicas to the each test specified name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Mon, Apr 01, 2019 at 05:13:32PM +0300, avtikhon wrote: > From: avtikhon > > --- > test/replication/before_replace.lua | 37 +++++ > test/replication/before_replace.result | 44 +++--- > test/replication/before_replace.test.lua | 44 +++--- > test/replication/before_replace1.lua | 1 + > test/replication/before_replace2.lua | 1 + > test/replication/before_replace3.lua | 1 + > test/replication/catch.result | 22 +-- > test/replication/catch.test.lua | 22 +-- > test/replication/ddl.lua | 4 +- > test/replication/errinj.result | 70 +++++----- > test/replication/errinj.test.lua | 70 +++++----- > test/replication/force_recovery.result | 16 +-- > test/replication/force_recovery.test.lua | 16 +-- > test/replication/gc.result | 49 +++---- > test/replication/gc.test.lua | 38 +++-- > test/replication/gc_no_space.result | 22 +-- > test/replication/gc_no_space.test.lua | 22 +-- > test/replication/hot_standby.result | 22 +-- > test/replication/hot_standby.test.lua | 22 +-- > test/replication/join_vclock.result | 9 +- > test/replication/join_vclock.test.lua | 8 +- > test/replication/local_spaces.result | 18 +-- > test/replication/local_spaces.test.lua | 18 +-- > test/replication/lua/fast_replica.lua | 125 +++++++++++++---- > test/replication/misc.lua | 37 +++++ > test/replication/misc.result | 132 +++++++++--------- > test/replication/misc.test.lua | 132 +++++++++--------- > test/replication/misc1.lua | 1 + > test/replication/misc2.lua | 1 + > test/replication/misc3.lua | 1 + > test/replication/on_replace.result | 14 +- > test/replication/on_replace.test.lua | 14 +- > test/replication/prune.result | 38 ++--- > test/replication/prune.test.lua | 35 ++--- > test/replication/quorum.result | 32 ++--- > test/replication/quorum.test.lua | 32 ++--- > test/replication/recover_missing_xlog.lua | 37 +++++ > test/replication/recover_missing_xlog.result | 18 ++- > .../replication/recover_missing_xlog.test.lua | 18 ++- > test/replication/recover_missing_xlog1.lua | 1 + > test/replication/recover_missing_xlog2.lua | 1 + > test/replication/recover_missing_xlog3.lua | 1 + > test/replication/replica_rejoin.result | 52 +++---- > test/replication/replica_rejoin.test.lua | 52 +++---- > test/replication/replica_uuid_ro1.lua | 1 - > test/replication/replica_uuid_ro2.lua | 1 - > test/replication/replica_uuid_ro3.lua | 1 - > ...a_uuid_ro.lua => replicaset_ro_mostly.lua} | 6 +- > test/replication/replicaset_ro_mostly.result | 6 +- > .../replication/replicaset_ro_mostly.test.lua | 6 +- > test/replication/replicaset_ro_mostly1.lua | 1 + > test/replication/replicaset_ro_mostly2.lua | 1 + > test/replication/replicaset_ro_mostly3.lua | 1 + > test/replication/show_error_on_disconnect.lua | 38 +++++ > .../show_error_on_disconnect.result | 12 +- > .../show_error_on_disconnect.test.lua | 12 +- > .../replication/show_error_on_disconnect1.lua | 1 + > .../replication/show_error_on_disconnect2.lua | 1 + > .../replication/show_error_on_disconnect3.lua | 1 + > test/replication/skip_conflict_row.result | 36 ++--- > test/replication/skip_conflict_row.test.lua | 36 ++--- > test/replication/status.result | 24 ++-- > test/replication/status.test.lua | 24 ++-- > test/replication/sync.result | 28 ++-- > test/replication/sync.test.lua | 28 ++-- > test/replication/wal_rw_stress.result | 22 +-- > test/replication/wal_rw_stress.test.lua | 22 +-- > 67 files changed, 938 insertions(+), 721 deletions(-) > create mode 100644 test/replication/before_replace.lua > create mode 120000 test/replication/before_replace1.lua > create mode 120000 test/replication/before_replace2.lua > create mode 120000 test/replication/before_replace3.lua > create mode 100644 test/replication/misc.lua > create mode 120000 test/replication/misc1.lua > create mode 120000 test/replication/misc2.lua > create mode 120000 test/replication/misc3.lua > create mode 100644 test/replication/recover_missing_xlog.lua > create mode 120000 test/replication/recover_missing_xlog1.lua > create mode 120000 test/replication/recover_missing_xlog2.lua > create mode 120000 test/replication/recover_missing_xlog3.lua > delete mode 120000 test/replication/replica_uuid_ro1.lua > delete mode 120000 test/replication/replica_uuid_ro2.lua > delete mode 120000 test/replication/replica_uuid_ro3.lua > rename test/replication/{replica_uuid_ro.lua => replicaset_ro_mostly.lua} (83%) > create mode 120000 test/replication/replicaset_ro_mostly1.lua > create mode 120000 test/replication/replicaset_ro_mostly2.lua > create mode 120000 test/replication/replicaset_ro_mostly3.lua > create mode 100644 test/replication/show_error_on_disconnect.lua > create mode 120000 test/replication/show_error_on_disconnect1.lua > create mode 120000 test/replication/show_error_on_disconnect2.lua > create mode 120000 test/replication/show_error_on_disconnect3.lua <..stripped the diff itself..> (Sorry for the late response.) I understood your idea, but I would prefer to write an instance script as part of a test. See my thoughts in https://github.com/tarantool/test-run/issues/305 And I would not rewrite everything at once. I think it is better to refactor a test, when you're working on it. At this point you have all aspects in the head and can achieve the best result for given piece of code (it is not so, when you're doing a bulk update). WBR, Alexander Turenko.