Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64
Date: Wed, 19 May 2021 16:04:00 +0300	[thread overview]
Message-ID: <20210519130400.GS3944@tarantool.org> (raw)
In-Reply-To: <591454EB-836C-4466-941C-0AE33597ABC6@tarantool.org>


On 18.05.21, Sergey Ostanevich wrote:
> Hi! 
> Thanks for the patch!
> My test run passes:
> $ ./test-run.py 5983
> Statistics:
> * pass: 1
> As for comment on opt.start - I’m not sure if we will ever change the threshold
> for optimizations - better to keep it under control and do not rely on a magic 100
> loop counter.

Hence, I mentioned that jit.opt.start call makes the test more robust.

> But the essence of the test is not clear to me: we just verify that on the host
> platform (the one testing is done) jit.dump is operable? I believe it should be
> put into original message then - ’to enable jit.dump on ARM64…'

Indeed. We just check, that all compiler phases are dumped (so all
necessary modules are successfully loaded). Thanks for noticing, I've
updated the commit message the following way:
| Since commit c9d88d5f48054d78727b587fef7567422cdc39a6 ('Fix #984: add
| jit.* library to the binary') all required modules implemented in Lua
| are bundled (i.e. compiled into the executable as a C literal) into
| Tarantool binary. While making Tarantool work on ARM64 platforms, it
| turned out the arch-specific module (namely, jit/dis_arm64.lua) is not
| bundled. Within this patch the missing sources are added and jit.dump
| works fine on ARM64 hosts as a result.

> Otherwise - LGTM.

Great, thanks!

> Sergos



Best regards,

  reply	other threads:[~2021-05-19 13:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  8:29 Igor Munkin via Tarantool-patches
2021-05-11  7:08 ` Sergey Kaplun via Tarantool-patches
2021-05-11  8:28   ` Igor Munkin via Tarantool-patches
2021-05-14 13:13 ` Sergey Ostanevich via Tarantool-patches
2021-05-17  8:39   ` Igor Munkin via Tarantool-patches
2021-05-17 16:34 ` Igor Munkin via Tarantool-patches
2021-05-18  7:14   ` Sergey Kaplun via Tarantool-patches
2021-05-18 15:34     ` Sergey Ostanevich via Tarantool-patches
2021-05-19 13:04       ` Igor Munkin via Tarantool-patches [this message]
2021-05-19 12:19     ` Igor Munkin via Tarantool-patches
2021-05-19 16:55       ` Sergey Kaplun via Tarantool-patches
2021-05-19 17:20 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519130400.GS3944@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox