From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B5E656C1AE; Wed, 19 May 2021 16:04:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5E656C1AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621429449; bh=ao4zyfAmxRln/Oysjp1D+2wV19IkyczgR3BGzwOE7Uk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ybO+cakptT3+3L/q3RceLlgr611vAwx5P7Pan6Y37Ld6aOtPZoPTQDkmaV619Cu0A u9c4lyv/z0exIHpIA+EVYMVSO+cXjsdiBFM6q1/z4jO25VCEB2rXg4VJ773BY8h5GQ LAnSxdQTD1LaqbK47EfgJyM3eP542kASqbrORc7A= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D48A16C1AE for ; Wed, 19 May 2021 16:04:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D48A16C1AE Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1ljLrl-0006Fx-P0; Wed, 19 May 2021 16:04:02 +0300 Date: Wed, 19 May 2021 16:04:00 +0300 To: Sergey Ostanevich Message-ID: <20210519130400.GS3944@tarantool.org> References: <72c91a259dd039fc95961992ae06baee820695be.1620072340.git.imun@tarantool.org> <20210517163433.GN3944@tarantool.org> <591454EB-836C-4466-941C-0AE33597ABC6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <591454EB-836C-4466-941C-0AE33597ABC6@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AFFAE5AC8370B8C7D84BE9C2CBFD04F41900894C459B0CD1B9724540BE791D6D2D8E3482DFFB869E5F8B86E0879B6F75B8115177133B14DDE9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78981306C6E927004EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B240711DC7F6A71F9D1A7C067F3A31DDF6AA867293B0326636D2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7E4DF6D1C10F22F599FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E6252C6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A508219B7BEB6BA91C5C2F854C719B8AEA2866E7DE80C347CCD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3403182E70AE6895E0C522D7E24CB6C0A4E882F2F26880F9601604727CC4307E732CEF432A5CF82FE51D7E09C32AA3244C952E6D35D1070D850B7C825FA98617EFB038C9161EF167A1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojF35yOkZDoIVjjpxywdzaBg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382231699A03BB930DF4337AD65F41B09279A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: add missing module for jit.dump on ARM64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, On 18.05.21, Sergey Ostanevich wrote: > Hi! > > Thanks for the patch! > > My test run passes: > $ ./test-run.py 5983 > Statistics: > * pass: 1 > > As for comment on opt.start - I’m not sure if we will ever change the threshold > for optimizations - better to keep it under control and do not rely on a magic 100 > loop counter. Hence, I mentioned that jit.opt.start call makes the test more robust. > > But the essence of the test is not clear to me: we just verify that on the host > platform (the one testing is done) jit.dump is operable? I believe it should be > put into original message then - ’to enable jit.dump on ARM64…' Indeed. We just check, that all compiler phases are dumped (so all necessary modules are successfully loaded). Thanks for noticing, I've updated the commit message the following way: | Since commit c9d88d5f48054d78727b587fef7567422cdc39a6 ('Fix #984: add | jit.* library to the binary') all required modules implemented in Lua | are bundled (i.e. compiled into the executable as a C literal) into | Tarantool binary. While making Tarantool work on ARM64 platforms, it | turned out the arch-specific module (namely, jit/dis_arm64.lua) is not | bundled. Within this patch the missing sources are added and jit.dump | works fine on ARM64 hosts as a result. > > Otherwise - LGTM. Great, thanks! > > Sergos > > -- Best regards, IM