Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling.

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergos,

On 12.05.21, Sergey Ostanevich wrote:
> Hi!
> 
> I can’t get this then
> 
>   src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS

There is a verbose comment nearby[1] and the corresponding issue[2].

> 
> How’s that survived in 2.1 branch?
> 
> regards,
> Sergos
> 
> 
> > On 11 May 2021, at 14:31, Igor Munkin <imun@tarantool.org> wrote:
> > 
> > Sergey,
> > 
> > Thanks for your review!
> > 
> > On 11.05.21, Sergey Kaplun wrote:
> >> Hi, Igor!
> >> 
> >> Thanks for the patch!
> >> LGTM!
> > 
> > Added your tag:
> > | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
> > 
> > Also mentioned the issue[1]:
> > | Resolves tarantool/tarantool#6066
> > 
> >> 
> >> -- 
> >> Best regards,
> >> Sergey Kaplun
> > 
> > [1]: https://github.com/tarantool/tarantool/issues/6066
> > 
> > -- 
> > Best regards,
> > IM
> 

[1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119
[2]: https://github.com/LuaJIT/LuaJIT/issues/668

-- 
Best regards,
IM