From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse
Date: Fri, 30 Apr 2021 08:13:29 +0000 [thread overview]
Message-ID: <20210430081329.qzzzw3daqx2il7np@tarantool.org> (raw)
In-Reply-To: <20210428102251.552976-1-gorcunov@gmail.com>
Hello,
On 28 апр 13:22, Cyrill Gorcunov wrote:
> v2 (by Vlad):
> - Use explicit != 0 form for flag testing
> - in Lua's fiber:join() drop the test for FIBER_IS_JOINABLE
> flag since now we do the same on lower level
> - extend tests
> - provide changelog
>
> issue https://github.com/tarantool/tarantool/issues/6046
> branch gorcunov/gh-6046-fiber-join-2
>
> Cyrill Gorcunov (2):
> fiber: fiber_join -- drop redundat variable
> fiber: fiber_join -- don't crash on misuse
>
> .../unreleased/gh-6046-fiber-join-misuse.md | 6 ++++
> src/lib/core/fiber.c | 12 +++++--
> src/lua/fiber.c | 10 ++++--
> test/app/fiber.result | 34 +++++++++++++++++++
> test/app/fiber.test.lua | 12 +++++++
> test/unit/fiber.cc | 7 ++++
> 6 files changed, 75 insertions(+), 6 deletions(-)
> create mode 100644 changelogs/unreleased/gh-6046-fiber-join-misuse.md
I've checked your patchset into 2.8 and master.
ALso, cherry-picked top patch to 2.7.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-04-30 8:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 10:22 Cyrill Gorcunov via Tarantool-patches
2021-04-28 10:22 ` [Tarantool-patches] [PATCH v2 1/2] fiber: fiber_join -- drop redundat variable Cyrill Gorcunov via Tarantool-patches
2021-04-28 15:13 ` Serge Petrenko via Tarantool-patches
2021-04-28 10:22 ` [Tarantool-patches] [PATCH v2 2/2] fiber: fiber_join -- don't crash on misuse Cyrill Gorcunov via Tarantool-patches
2021-04-28 15:13 ` Serge Petrenko via Tarantool-patches
2021-04-28 15:21 ` Cyrill Gorcunov via Tarantool-patches
2021-04-28 15:34 ` Serge Petrenko via Tarantool-patches
2021-04-28 21:16 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-28 22:12 ` Cyrill Gorcunov via Tarantool-patches
2021-04-29 11:10 ` [Tarantool-patches] [PATCH v3 " Cyrill Gorcunov via Tarantool-patches
2021-04-29 19:37 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-29 20:39 ` Cyrill Gorcunov via Tarantool-patches
2021-04-29 21:10 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-30 8:13 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430081329.qzzzw3daqx2il7np@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox