From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B44AE6EC5F; Fri, 30 Apr 2021 11:13:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B44AE6EC5F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619770413; bh=3SRpEItGQ0O15Jp4rLdlIrM1MSbo9kmOXuhYDniIwLc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=IUOqnP4gTWkutUCdCNUcGt44PMEsTOdo+H86eAp2dlu8CU3X6l5ImtbT6c00PCK/I qk6vTR5XWvoA2oygYsuYhO8kGGYBSBFX5pNVHmdLfco3L81FRhxVM8A2Lp3qpVkBlB 5CvPg9vz6N1YLWp5BhIytTawDnzDprF2HXtDefPg= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EEE0D6EC5F for ; Fri, 30 Apr 2021 11:13:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EEE0D6EC5F Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1lcOHB-0000J9-Iq; Fri, 30 Apr 2021 11:13:29 +0300 Date: Fri, 30 Apr 2021 08:13:29 +0000 To: Cyrill Gorcunov Message-ID: <20210430081329.qzzzw3daqx2il7np@tarantool.org> References: <20210428102251.552976-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210428102251.552976-1-gorcunov@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0FB16CA32063744B94D060C3A2F6991A4182A05F538085040612E096E36EAC3672564BA32BB74E50A7ECF82871905957F31BD3AC9E2C0A0BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7374BF80023594226EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764BF1E09E94CC6278638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B21CFA2274BBF1BE3E0C0B6246662E9BDEFEEB761FB9071033D2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE77E7E81EEA8A9722B8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C010E539FDDD93021D7B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050F1E561CDFBCA1751FC766E17BBE5724E9B3661434B16C20AC78D18283394535A9E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B53A69B3AC30C7B9475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A521FCD159700D3759C2326A0F9C8F9F3A75DDBD215D242E3BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349A949488F6BF46DDC96086074CE1529A2A382DFDD6031C9E15C2621C00B6580ED2C0CA888B488A3A1D7E09C32AA3244C8E2183566C625FBD7A5162E9A6E7390C435BF7150578642F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojVCmWsvwT1HZFQMCMCpsWxQ== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2829A6C62B7216E9229B0EC543C2F0374191FF8DA59C9521CCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 0/2] fiber: prevent fiber_join from misuse X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 28 апр 13:22, Cyrill Gorcunov wrote: > v2 (by Vlad): > - Use explicit != 0 form for flag testing > - in Lua's fiber:join() drop the test for FIBER_IS_JOINABLE > flag since now we do the same on lower level > - extend tests > - provide changelog > > issue https://github.com/tarantool/tarantool/issues/6046 > branch gorcunov/gh-6046-fiber-join-2 > > Cyrill Gorcunov (2): > fiber: fiber_join -- drop redundat variable > fiber: fiber_join -- don't crash on misuse > > .../unreleased/gh-6046-fiber-join-misuse.md | 6 ++++ > src/lib/core/fiber.c | 12 +++++-- > src/lua/fiber.c | 10 ++++-- > test/app/fiber.result | 34 +++++++++++++++++++ > test/app/fiber.test.lua | 12 +++++++ > test/unit/fiber.cc | 7 ++++ > 6 files changed, 75 insertions(+), 6 deletions(-) > create mode 100644 changelogs/unreleased/gh-6046-fiber-join-misuse.md I've checked your patchset into 2.8 and master. ALso, cherry-picked top patch to 2.7. -- Regards, Kirill Yukhin