From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change
Date: Thu, 22 Apr 2021 14:34:45 +0300 [thread overview]
Message-ID: <20210422113445.270688-1-gorcunov@gmail.com> (raw)
In-Reply-To: <20210419083719.29689-1-gorcunov@gmail.com>
There is no need to test @confirm_lsn since we're
continue the list traversing in any case.
I keep "continue" here to be consistent with other "if"s.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/txn_limbo.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c
index 0ac8fff25..c07db3025 100644
--- a/src/box/txn_limbo.c
+++ b/src/box/txn_limbo.c
@@ -707,8 +707,7 @@ txn_limbo_on_parameters_change(struct txn_limbo *limbo)
assert(e->ack_count <= VCLOCK_MAX);
if (!txn_has_flag(e->txn, TXN_WAIT_ACK)) {
assert(e->lsn == -1);
- if (confirm_lsn == -1)
- continue;
+ continue;
} else if (e->ack_count < replication_synchro_quorum) {
continue;
} else {
--
2.30.2
next prev parent reply other threads:[~2021-04-22 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 8:37 [Tarantool-patches] [PATCH 0/3] wal,txn_limbo: a few cleanups Cyrill Gorcunov via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 1/3] wal: sanitize wal_mode Cyrill Gorcunov via Tarantool-patches
2021-04-23 20:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-23 21:17 ` Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:08 ` Serge Petrenko via Tarantool-patches
2021-04-25 13:26 ` Cyrill Gorcunov via Tarantool-patches
2021-04-26 9:40 ` Serge Petrenko via Tarantool-patches
2021-04-26 9:58 ` Cyrill Gorcunov via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 2/3] txn_limbo: simplify owner migration condition Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:09 ` Serge Petrenko via Tarantool-patches
2021-04-19 8:37 ` [Tarantool-patches] [PATCH 3/3] txn_limbo: simplify txn_limbo_ack Cyrill Gorcunov via Tarantool-patches
2021-04-25 8:11 ` Serge Petrenko via Tarantool-patches
2021-04-22 11:34 ` Cyrill Gorcunov via Tarantool-patches [this message]
2021-04-25 8:13 ` [Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change Serge Petrenko via Tarantool-patches
2021-04-25 13:18 ` [Tarantool-patches] [PATCH 0/3] wal,txn_limbo: a few cleanups Vladislav Shpilevoy via Tarantool-patches
2021-04-26 15:40 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422113445.270688-1-gorcunov@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 4/4] txn_limbo: simplify txn_limbo_on_parameters_change' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox