Re: [Tarantool-patches] [PATCH v2 luajit 03/30] test: adapt Lua 5.1 suite for out-of-source build

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

On 26.03.21, Sergey Kaplun wrote:
> Hi!
> 
> Thanks for the review!
> 
> On 26.03.21, Sergey Ostanevich wrote:
> > LGTM, just minor changes to commit message.
> > 
> > Sergos
> > 
> > 
> > > On 26 Mar 2021, at 10:42, Sergey Kaplun <skaplun@tarantool.org> wrote:
> > > 
> > > When tests are run out-of-source redefined `dofile()` function
> >                                   ^ I had problem reading here the 
> > ‘out-of-source redefined’. Can you put the ‘when..’ to the appropriate
> > place at the end of the sentence? ’The redefined … when … ‘
> 
> Fixed.
> 
> The new committ message is the following (branch is force-pushed):

But what is fixed in the new version? I see the sentence Sergos asked to
reword is left intact.

> 
> ===================================================================
> test: adapt Lua 5.1 suite for out-of-source build
> 
> When tests are run out-of-source redefined `dofile()` function failed to
> find the test file to load. So, fullpath is detected considering
> `arg[0]` value. Moreover, some tests use `loadfile()` instead, so their
> argument is adjusted to the full path to the files.
> 
> However, test in <verybig.lua> creates a temporary file
> and executes it via `dofile()` too, so this case is handled by
> the second argument -- `prefix` equals an empty string for
> current working directory.
> 
> Part of tarantool/tarantool#5845
> Part of tarantool/tarantool#4473
> ===================================================================
> 
> >  
> > > failed to find file to load. So, fullpath is detected considering
> > > `arg[0]` value. Moreover, some tests use `loadfile()` instead, so
> > > their argument is adjusted to the full path to the files.
> > > 
> > > However, test in <verybig.lua> creates a temporary file
> > > and executes it via `dofile()` too, so this case is handled by
> > > the second argument -- `prefix` equals an empty string for
> > > current working directory.
> > > 
> > > Part of tarantool/tarantool#5845
> > > Part of tarantool/tarantool#4473

<snipped>

> > > -- 
> > > 2.31.0
> > > 
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM