From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event
Date: Mon, 29 Mar 2021 23:48:47 +0300 [thread overview]
Message-ID: <20210329204847.GP29703@tarantool.org> (raw)
In-Reply-To: <20210309175422.25432-1-skaplun@tarantool.org>
Sergey,
I've checked the series into tarantool-2.7 and tarantool branches in
tarantool/luajit and bumped a new version in 2.7 and master.
On 09.03.21, Sergey Kaplun wrote:
> Resizing of the Lua stack is not reported as internal allocation.
> Moreover, it may lead to crash inside Lua or FF frames.
>
> Profiler performs reallocation first and after reports corresponding
> event. When the stack is resized for local function arguments, the link
> to previous frame is invalid in the cause of reallocation. Therefore,
> assertion in `debug_framepc()` failes, because of invalid function
> reference at previous frame.
>
> Resolves tarantool/tarantool#5842
> Follows up tarantool/tarantool#5442
> ---
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5842-memprof-core-on-resizestack
> Tarantool branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5842-memprof-core-on-resizestack
> Issue: https://github.com/tarantool/tarantool/issues/5842
>
>
> src/lj_state.c | 6 ++++++
> .../misclib-memprof-lapi.test.lua | 18 ++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
<snipped>
> --
> 2.28.0
>
--
Best regards,
IM
prev parent reply other threads:[~2021-03-29 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 17:54 Sergey Kaplun via Tarantool-patches
2021-03-10 14:59 ` Sergey Ostanevich via Tarantool-patches
2021-03-10 17:37 ` Sergey Kaplun via Tarantool-patches
2021-03-25 20:14 ` Igor Munkin via Tarantool-patches
2021-03-26 8:54 ` Sergey Kaplun via Tarantool-patches
2021-03-26 10:10 ` Igor Munkin via Tarantool-patches
2021-03-26 14:09 ` Sergey Kaplun via Tarantool-patches
2021-03-26 18:38 ` Igor Munkin via Tarantool-patches
2021-03-29 8:09 ` Sergey Kaplun via Tarantool-patches
2021-03-29 8:32 ` Igor Munkin via Tarantool-patches
2021-03-29 8:35 ` Igor Munkin via Tarantool-patches
2021-03-29 16:01 ` Sergey Ostanevich via Tarantool-patches
2021-03-29 20:48 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329204847.GP29703@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox