Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for the fixes! I'll push it to the trunk as soon as Sergos gives
his LGTM.

On 29.03.21, Sergey Kaplun wrote:
> Igor,
> 
> Thanks for the review!
> 

<snipped>

> 
> Missed ChangeLog entry, feel free to change it at your pleasure:

Great, thanks! I propose the following wording:

| ##feature/luajit
|
| * Make LuaJIT memory profiler parser output more user-friendly (gh-5811).
|   Now the source line definition where the event occurs is much clearer:
|   only source file name and allocation-related line are presented,
|   function definition line number is omitted. Moreover, event-related
|   statistics are indicated with units.
|   **Breaking change**: Line info of the line function definition is
|   saved in symbol info table by field `linedefined` now and field `name`
|   is renamed to `source` with the respect to Lua Debug API.

> 
> ===================================================================
> ##feature/luajit
> 
> * Make LuaJIT memory profiler parser output more user-friendly (gh-5811).
>   **Breaking change**: Info
>   about the line function definition is saved inside symbol info table by
>   field `linedefined` now. Field `name` was renamed to `source`.
> ===================================================================
> 
> > 
> > <snipped>
> > 
> > > diff --git a/tools/memprof/humanize.lua b/tools/memprof/humanize.lua
> > > index 109a39db..2d5814c6 100644
> > > --- a/tools/memprof/humanize.lua
> > > +++ b/tools/memprof/humanize.lua
> > > @@ -20,7 +20,7 @@ function M.render(events, symbols)
> > >  
> > >    for i = 1, #ids do
> > >      local event = events[ids[i]]
> > > -    print(string.format("%s: %d\t%d\t%d",
> > > +    print(string.format("%s: %d events\t+%d bytes\t-%d bytes",
> > 
> > Minor: Heh, "events" is still plural even if <event.num> is 1. Feel free
> > to ignore (the current implementation might ease the postprocessing).
> 
> Valgring use plural too for different kind of messages.

Lol, never notice this.

> | ==24036== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)
> 
> Ignoring.
> 

<snipped>

> > > -- 
> > > 2.31.0
> > > 
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM