From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9EC486EC60; Mon, 29 Mar 2021 14:16:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9EC486EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617016585; bh=1AYJQy/usQVlfw/6Uh6VzjnYmq5Vbymg7d2ikKf6Xok=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NxCbudvLnlNGB3iiNyoxQNEF3bIgCq2zfvWHCP30KPKRmVvEn5TEp5DlkPoG+WQ8t UkpWSPCjZ++updPc1tyG3m43QUB3wWZ/Gyus/ZUbKKKf1xTZ4hNyzvShfPiYnjqM/d uwXh8U1Q+8o1N35XSz5fZbg7R710sJQThJEjG6hc= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 472046EC60 for ; Mon, 29 Mar 2021 14:16:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 472046EC60 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lQpsd-0002TL-34; Mon, 29 Mar 2021 14:16:23 +0300 Date: Mon, 29 Mar 2021 14:16:13 +0300 To: Sergey Kaplun Message-ID: <20210329111613.GN29703@tarantool.org> References: <20210326164855.30242-1-skaplun@tarantool.org> <20210326203356.GJ29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F538085040FBC690E7D4D502AD263983F4E0D07279B9149F642686C4C4054D9F2D43976E40 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379F6495389D012EA98638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662D3569DF18536AAC49A4EFF0D3C22C445CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A57E65E103CA5BE8B490466414EF43F39B651E4734B6B6F05BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346BEB6F73FB9D1E4A5D0EDBDD6AA36DC72EE088FC206866ACF995365C7363BCBE5FD1E5471BD41F2E1D7E09C32AA3244C78DCAA413A7C3CCE8ED598BC3F3371427101BF96129E4011927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rQFF7hzLM8/Vg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382241D92F945D338467C7635A7264881690A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] tools: make memprof parser output user-friendly X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the fixes! I'll push it to the trunk as soon as Sergos gives his LGTM. On 29.03.21, Sergey Kaplun wrote: > Igor, > > Thanks for the review! > > > Missed ChangeLog entry, feel free to change it at your pleasure: Great, thanks! I propose the following wording: | ##feature/luajit | | * Make LuaJIT memory profiler parser output more user-friendly (gh-5811). | Now the source line definition where the event occurs is much clearer: | only source file name and allocation-related line are presented, | function definition line number is omitted. Moreover, event-related | statistics are indicated with units. | **Breaking change**: Line info of the line function definition is | saved in symbol info table by field `linedefined` now and field `name` | is renamed to `source` with the respect to Lua Debug API. > > =================================================================== > ##feature/luajit > > * Make LuaJIT memory profiler parser output more user-friendly (gh-5811). > **Breaking change**: Info > about the line function definition is saved inside symbol info table by > field `linedefined` now. Field `name` was renamed to `source`. > =================================================================== > > > > > > > > > > diff --git a/tools/memprof/humanize.lua b/tools/memprof/humanize.lua > > > index 109a39db..2d5814c6 100644 > > > --- a/tools/memprof/humanize.lua > > > +++ b/tools/memprof/humanize.lua > > > @@ -20,7 +20,7 @@ function M.render(events, symbols) > > > > > > for i = 1, #ids do > > > local event = events[ids[i]] > > > - print(string.format("%s: %d\t%d\t%d", > > > + print(string.format("%s: %d events\t+%d bytes\t-%d bytes", > > > > Minor: Heh, "events" is still plural even if is 1. Feel free > > to ignore (the current implementation might ease the postprocessing). > > Valgring use plural too for different kind of messages. Lol, never notice this. > | ==24036== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0) > > Ignoring. > > > > -- > > > 2.31.0 > > > > > > > -- > > Best regards, > > IM > > -- > Best regards, > Sergey Kaplun -- Best regards, IM