Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v1] tools: introduce --leak-only memprof parser option
Date: Mon, 29 Mar 2021 12:41:10 +0300	[thread overview]
Message-ID: <20210329094110.GM29703@tarantool.org> (raw)
In-Reply-To: <20210125193544.18050-1-skaplun@tarantool.org>


Thanks for the patch! This is definitely not "view" in terms of memprof.
This is a routine that post-process the parsed and grouped data. There
was no such stage before: the binary profile is parsed into events and
then events are rendered in a human-readable format. If you introduced
the new output format (e.g. JSON, YAML, etc), then it would be a "view",
since we don't need to test how Lua tables are converted into JSON
objects. But in this patch, you post-process the parsed events into
another structure based on the user's request (i.e. show only leaks).
Hence, this post-processing *need to be tested* at least as a so-called
"black box". You provide no tests for you patch at all, so if something
is broken we'll know it only from the customer's feedback.

I propose to reconsider the way you introduced this feature and provide
some tests for it (the latter is the main problem).

Best regards,

      parent reply	other threads:[~2021-03-29  9:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 19:35 Sergey Kaplun via Tarantool-patches
2021-01-29 15:17 ` Sergey Ostanevich via Tarantool-patches
2021-03-17 15:03   ` Sergey Kaplun via Tarantool-patches
2021-03-29 15:50     ` Sergey Ostanevich via Tarantool-patches
2021-03-29  9:41 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210329094110.GM29703@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v1] tools: introduce --leak-only memprof parser option' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox