From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 724256EC60; Mon, 29 Mar 2021 12:41:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 724256EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617010882; bh=STdY+5usjt0bGnfqpVi0z71U06n3USGZlWdSknxF8bQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OMJLdHNIZmIsJA1Vi8wamd8aC0RVfJ0K2daa+Mol/tFXu2jmxu86u3xjpdZ91RJqo Qgk4XdJMBiUD8cvnHs9i+b2Gnuydl3eFWdE6APnzVP7EFxf5oNwAFunNDXDrNy7fG4 F1M99tzC5wG07XEYr6LyJF1k0euTVAsr95RZvmMM= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AC59C6EC60 for ; Mon, 29 Mar 2021 12:41:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC59C6EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lQoOd-0008Pc-G0; Mon, 29 Mar 2021 12:41:20 +0300 Date: Mon, 29 Mar 2021 12:41:10 +0300 To: Sergey Kaplun Message-ID: <20210329094110.GM29703@tarantool.org> References: <20210125193544.18050-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210125193544.18050-1-skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F5380850406106EC060A842A72142D4C418A043A2BA153471E4D8DFA858772330BE5D13311 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EEA194BB48C104EF8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7428A34725AB662DF717AFD40BBC29E470183270CEA57D00A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5BE7278E71D1A220D3498EEB6A07D92001E0F9E7A222D6934D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C75F910DBB8BE898CDD0EDA9C6BDE52F626B13AAF2C50534FC721A9733D449B970F533195A2FBF181D7E09C32AA3244C99BFA974D183A0E4F70AC90A358EF512B038C9161EF167A1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rTiZV5+9umzFA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C34599EF44714936A6C6B3E917298D71A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1] tools: introduce --leak-only memprof parser option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch! This is definitely not "view" in terms of memprof. This is a routine that post-process the parsed and grouped data. There was no such stage before: the binary profile is parsed into events and then events are rendered in a human-readable format. If you introduced the new output format (e.g. JSON, YAML, etc), then it would be a "view", since we don't need to test how Lua tables are converted into JSON objects. But in this patch, you post-process the parsed events into another structure based on the user's request (i.e. show only leaks). Hence, this post-processing *need to be tested* at least as a so-called "black box". You provide no tests for you patch at all, so if something is broken we'll know it only from the customer's feedback. I propose to reconsider the way you introduced this feature and provide some tests for it (the latter is the main problem). -- Best regards, IM