Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 29.03.21, Igor Munkin wrote:
> Sergey,
> 
> On 29.03.21, Sergey Kaplun wrote:
> > Igor,
> > 
> 
> <snipped>
> 
> > > > > 
> > > > > "Feel free to prove the opposite"(c) :)
> > > > > 
> > > > > The current naming is much better than the previous one, but I still
> > > > > propose to save the original on and save G(L) into a new variable.
> > > > 
> > > > Ignoring for now.
> > > 
> > > Well, if you just need my LGTM, you got it. I'll even push this patch by
> > > myself. But try to hear my arguments even if they look like "bred deda".
> > 
> > This is not about LGTM, but about a miscommunication, I hope we will
> > understand each other's point of view and come to a consensus.
> 
> I see no changes on the branch, hence we won't. Anyway, you have the
> necessary amount of LGTMs, so I'll push your patch to the trunk later.

Oops, seems you have only mine (at least I see no explicit LGTM from
Sergos in the thread). Will not rush then.

> 
> > 
> 
> <snipped>
> 
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM