From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E2AD06EC60; Mon, 29 Mar 2021 11:36:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E2AD06EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617006969; bh=nwKd28lS0uf19wvPVS+HUMKNUdM7LB+Knk72AebtXEA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iLz5xs+iqOcTAG2lxngOapu/f+fan3yyRO30wT1tRiN69tA6ISShwhTNNrJSLQaLM Y3fBVirMkkPbfOO22I/hgpITw9ZdJzvXiBqWUWZOb7kWVL8Z7J17TUqXA0OgSSsJmB lLxwTSSNgKJHD/bU33PbrCudG4r6OLGQIFSJj2jA= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9C0AF6EC60 for ; Mon, 29 Mar 2021 11:36:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9C0AF6EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lQnNY-000688-Px; Mon, 29 Mar 2021 11:36:09 +0300 Date: Mon, 29 Mar 2021 11:35:59 +0300 To: Sergey Kaplun Message-ID: <20210329083559.GL29703@tarantool.org> References: <20210309175422.25432-1-skaplun@tarantool.org> <20210325201459.GG29703@tarantool.org> <20210326101035.GH29703@tarantool.org> <20210326183856.GI29703@tarantool.org> <20210329083202.GK29703@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210329083202.GK29703@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F53808504086CF8A4D1FD7E50F22B152AA916C2055B24E080A9FC2E9DE6FA2F9F801AD3894 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD3501B5CE9C42E3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377E85B0EC44E8FD73EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76640E28EDD6CB140ADC740E9D4C7D23CA2BE5152FF078CC7282389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C69D4C8FA58DAC3AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5DE074A4D6AC9F6EE78416C3BF4EF280E73D271DEF64DE5B1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345C110A855FC09999AE9AE3A69F2215BD481EA29DFEDB646E1AD0A0FD1A4E59B0CB80424AEAB17E7D1D7E09C32AA3244C726DC89DCE04746DCEEAAE1040BFBB71F26BFA4C8A6946B8927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rQdN7yJaPf4gA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822259F839CC6C4FDC8E7AC9E4A72F9106CA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 29.03.21, Igor Munkin wrote: > Sergey, > > On 29.03.21, Sergey Kaplun wrote: > > Igor, > > > > > > > > > > > > > > > "Feel free to prove the opposite"(c) :) > > > > > > > > > > The current naming is much better than the previous one, but I still > > > > > propose to save the original on and save G(L) into a new variable. > > > > > > > > Ignoring for now. > > > > > > Well, if you just need my LGTM, you got it. I'll even push this patch by > > > myself. But try to hear my arguments even if they look like "bred deda". > > > > This is not about LGTM, but about a miscommunication, I hope we will > > understand each other's point of view and come to a consensus. > > I see no changes on the branch, hence we won't. Anyway, you have the > necessary amount of LGTMs, so I'll push your patch to the trunk later. Oops, seems you have only mine (at least I see no explicit LGTM from Sergos in the thread). Will not rush then. > > > > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, IM